Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparency problem when converting 32-bit images to WebP #8730

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

bep
Copy link
Member

@bep bep commented Jul 7, 2021

Fixes #8729

bep added 2 commits July 7, 2021 10:15
Keep this as a separate commit as this isn't because the files have changed. The filenames have changed due to cache busting of PNG and Webp images.

See gohugoio#8729
@bep bep force-pushed the fix/webp-tranp-8729 branch from 535cfd5 to bf3bdbe Compare July 7, 2021 08:43
@bep
Copy link
Member Author

bep commented Jul 7, 2021

The patch itself i rather small. The second commit, the regen of the golden test data, comes from incrementing the version numbers on PNG and Webp to make sure they get cache busted in the wild.

@bep bep requested a review from jmooring July 7, 2021 09:24
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested MRE, image from originating forum topic, photos, etc. Also made sure that cache was busted on an existing site. Looks good to me.

Thank you very much for the rapid response.

@bep bep merged commit 30eea39 into gohugoio:master Jul 7, 2021
@cromozooom
Copy link

Thank you guys

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transparency problem when converting 32-bit images to WebP
3 participants