Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exif: Log warning for metadata decode error #8684

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

IveGotNorto
Copy link
Contributor

The error is logged as a WARNING and nil is returned.

see #8519

@jmooring
Copy link
Member

@IveGotNorto Is there anyway to include the full path to the offending image? I have updated the minimal example for #8519 to include an additional assets mount (see config.toml). The resulting warning from this PR is:

WARN 2021/06/29 10:32:46 Unable to decode Exif metadata from image: /images/broken.jpg
WARN 2021/06/29 10:32:46 Unable to decode Exif metadata from image: /images/c.jpg

It would be helpful if the warnings were:

WARN 2021/06/29 10:32:46 Unable to decode Exif metadata from image: /foo/images/broken.jpg
WARN 2021/06/29 10:32:46 Unable to decode Exif metadata from image: /assets/images/c.jpg

I don't know is this is possible. What you have done so far is great. Thank you.

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants