Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for google analytics v4 #8287

Merged
merged 10 commits into from
Mar 3, 2021
Merged

Add support for google analytics v4 #8287

merged 10 commits into from
Mar 3, 2021

Conversation

torrayne
Copy link

Reopen #8264. I should've created a branch for the PR so that when I rebased master it didn't break everything. @coliff

The Google analytics template doesn't work with Google Analytics v4 (gtag.js) #7954. v3 analytics.js is not depreciated so we should support both using hasPrefix to tell the difference.

It should be noted that gtag uses the async attribute. Which is more like google_analytics_async.html. I'm not sure if we should move the changes to that template instead. The naming of the template is also confusing. See #8261.

Privacy settings anonymizeIP and respectDoNotTrack are supported while useSessionStorage is not. I could only find one document with instructions for session storage but in my testing it still set cookies.

@bep
Copy link
Member

bep commented Mar 2, 2021

/cc @coliff ? Looks good to me.

@bep bep merged commit ba16a14 into gohugoio:master Mar 3, 2021
@onedrawingperday onedrawingperday mentioned this pull request Mar 3, 2021
Closed
@joshgerdes joshgerdes mentioned this pull request Mar 18, 2021
Closed
@charlesLoder charlesLoder mentioned this pull request Mar 21, 2021
Closed
@c0ze c0ze mentioned this pull request Apr 2, 2021
Closed
@torrayne torrayne mentioned this pull request Apr 12, 2021
Closed
@xiantang xiantang mentioned this pull request May 20, 2021
Closed
@RichieEscarez RichieEscarez mentioned this pull request Jun 7, 2021
Merged
@gilcrest gilcrest mentioned this pull request Jun 16, 2021
Closed
@jbub jbub mentioned this pull request Jan 5, 2022
Closed
@freitzzz freitzzz mentioned this pull request Jan 8, 2022
Merged
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
@torrayne torrayne deleted the google-analytics-v4 branch March 4, 2022 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coliff coliff coliff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torrayne @bep @coliff