Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ContentBaseName() as fallback page Title #7890

Closed
wants to merge 1 commit into from

Conversation

rigtorp
Copy link

@rigtorp rigtorp commented Oct 26, 2020

Closes #7370
Closes #3805
Related to #6098

The use case is to quickly generate a site from a directory of markdown files without front matter.

It's also possible to parse ContentBaseName() and generate a better title, something like a unslugify() function.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2020

CLA assistant check
All committers have signed the CLA.

@rigtorp rigtorp force-pushed the fallback-page-title branch from 2e40022 to 5069ed9 Compare October 27, 2020 18:30
@bep
Copy link
Member

bep commented Dec 2, 2020

Thanks for this, and sorry for the delay. I understand the problem, and I suspect many people would want this patch applied. But it would be a breaking change (having no title could be a deliberate choice). One could think of adding some config option here, but I want to hold that thought until we see how "non file" content sources work in this context.

@bep bep closed this Dec 2, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants