Adds newline after 'Building Sites' message

[jwarner112]

As mentioned in #7579, the logs keep tripping me up so I made this change, and I'm hoping it helps annoy others less as well.

Going over the contributors' guidelines:

• Sign the CLA
• Test cases for the code -- this was so small I'm not sure if you'd make this rule apply? I manually verified it, at least
• go fmt was run, though it made no changes
• No docs, same reasoning as Test Cases. Let me know if you think otherwise!
• Squashed to one commit
• mage check finished with exit code 0
• Git commit message guidelines followed as best as I understood them

I think that's everything but I'm happy to discuss and make changes. 🤘

[bep]

2 comments:

• I suspect this change will break the "hide when done" logic; whether that logic is worth keeping is worth discussing.
• Also, have a look at the commit message guidelines (ref. the commit message title/subject)

[jwarner112]

I suspect this change will break the "hide when done" logic; whether that logic is worth keeping is worth discussing.

I'm not sure what you mean about the "hide when done" logic; I've run all the tests with no failure, and haven't found it yet to test manually. Where would I find it?

[bep]

I'm not sure what you mean about the "hide when done" logic;

The "Building sites..." message is just showing when the site is... building. It's removed from terminal when done. If you add a newline, that logic is broken.

[jwarner112]

Ooh, okay. I guess I've got a bug to report, then -- it's never hidden itself for me, to the point that I didn't know it was even supposed to. Here's what I've always gotten:

$ hugo
Building sites … WARN 2020/08/21 00:04:19 I'm a little teapot
WARN 2020/08/21 00:04:19 short and stout

                   | EN  
-------------------+-----
  Pages            | 28  
  Paginator pages  |  1  
  Non-page files   |  0  
  Static files     |  1  
  Processed images |  2  
  Aliases          |  4  
  Sitemaps         |  1  
  Cleaned          |  0  

Total in 96 ms
$

I would say that if that behavior were fixed, my problem would go away -- however, I think it would reach and display my warnf statements, and that the first of those might get erased when the Building Sites ... clears?

---

edit: System info

Linux: Linux jbox 5.4.0-42-generic #46~18.04.1-Ubuntu SMP Fri Jul 10 07:21:24 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
WM: GNOME 3.28.4
Terminal: GNOME Terminal 3.28.2 using VTE 0.52.2 +GNUTLS -PCRE2

[bep]

So, I added that clever construct, but I have seen it failing in some situations myself, so what I suggest you do as part of this is:

1. Add a newline (like this PR)
2. Remove the ifTerminal(hideCursor) logic (remove the function)
3. Edit the text from "Building sites …" to ... "Start building sites …"

[jwarner112]

Cool, cool! I've made those changes and I believe adequately resolved the commit message critique.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.