Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publisher: Fix tag collector for nested table elements #7320

Merged
merged 1 commit into from
May 27, 2020

Conversation

bep
Copy link
Member

@bep bep commented May 25, 2020

Fixes #7318

@jeromew
Copy link

jeromew commented May 26, 2020

I tried to understand why travis fails on this PR.

it says

quicktest.go:306: 
        error:
          unexpected length
        len(got):
          int(9)
        got:
          []string{"!doctype", "div", "head", "hr", "html", "link", "meta", "span", "title"}
        want length:
          int(8)
        stack:
          /home/travis/src/hugo/hugolib/site_test.go:1126
            b.Assert(els.Tags, qt.HasLen, 8)

Looking at the test, I can only guess that it is because <!doctype> was implicitly added, was impersonated as a div by the PR and as a consequence was added to the list of elements (?).
I hope this helps.

@bep bep force-pushed the fix/classcoll-thead branch from 0ecb712 to bfc481a Compare May 26, 2020 08:37
@bep bep merged commit c950c86 into gohugoio:master May 27, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thead and tbody classes do not appear in hugo_stats.json
2 participants