tpl: Fix bad rounding in NumFmt #7117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strconv.FormatFloat doesn't round properly sometimes, this adds a different method of rounding, fixes gohugoio#7116
moorereason
approved these changes
Jun 2, 2020
|
@bep, this PR looks good. Rounding floats is hard, especially with configurable precision. The approach taken here by @sams96 is the simplest all-around solution. It's not bulletproof since it can overflow at The Travis CI builds originally failed to run properly. I've restarted them. Once they're green, we should be clear to merge. 👍 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strconv.FormatFloat doesn't round properly sometimes, this adds a different method of rounding, fixes #7116