Add minify config

[satotake]

related #6750

This PR enables users to turn on/off by minifier types and to configure minify with its options
This is proposal and any comments and suggestions are welcome

content

• [mod] Update github.com/tdewolff/minify
• [minifiers] New config.go
• [docshelper] Add func merge DocProviders
• [docs] update docs.json

related issues

• Fixes Add option to disable inline SVG minification #6750
• partially “hugo --minify” strips spaces and preserve some new lines #6892 (preserve space)
• Fixes Upstream Keep single/double quotes in --minify #6621

edit:
By downgrading minify version, #6621 became an upstream issue

[bep]

This looks really good. I have 3 comments:

1. We cannot update tdewolff deps before we have verified the reason I had to roll back recently (it broke sites badly in the wild, including the Hugo site)

2. I have learned some lessons from Chroma/Blackfriday/Pygments ... there may be a new super minifier on the scene in a year ... with totally different options. So I suggest we split out the general and put the specifics below tdewolff (same as in the markup config)

3. I'm not sure about this one, but if I disable XML and do { { $xml : $xml | minify }} what happens? I assume I get myxml.min.xml but with unchanged content. I think we need to split the minifiers in two (one for the final content and the other for the minify func) ...?

[satotake]

Thanks for comment, @bep

1 & 2 are done

Please note that #6621 is not solved even by merging this because minify is not updated and does not have KeepQuotes option.

I admit that I am also not so confident about 3 but let me explain.

I disable XML and do { { $xml : $xml | minify }} what happens?

Minification of resource raises error and cause build fail when you unset the minfier.
On the other hand, minification of inline contents in .html file never raises error.

That is my intention but it is so vague as specification that I have just added a test case and improved the error message.

Second,

I think we need to split the minifiers in two (one for the final content and the other for the minify func) ...?

It is possible to separate content minifier from resource minifier in terms of both configurations and processing behaviour (I mean #6724 ).
However I believe that it will be better to use at least single configuration because

1. It reduces configuration simplicity (Hugo's advantage)
2. Most of users who configure minification demand lower level of minification and higher validity of contents. It will be better to apply more secure settings for them in sites' scope.
3. Required settings of minification vary with users' situations but they are independent of whether minification targets are derived from content (layout) or resource
4. these speculations may be wrong but they can be separated later.

[bep]

Thanks for this. I think we need to settle 3 before we can wrap this.

{ { $xml := $xml | minify }} 

I think I would expect the above to just silently drop the minify statement if I disable minify, that statement could well live in a theme I don't control.

But you are probably right (?) about having 1 disable for both of these. We can consider adding some flag later if needed.

/cc @kaushalmodi @regisphilibert

[regisphilibert]

I can see enabling/disabling is made by Type so it seems very controllable. I'm not familiar with mifnication technology.

I'm simply curious of what happens if a CSS file's minified .Content

{{ ($style | minified).Content }}

is printed in an HTML file. I suppose if CSS minification is disabled, but HTML is not, then the HTML minification will take care of minifying the CSS?

[bep]

then the HTML minification will take care of minifying the CSS?

Not if you include it in style tags (which I assume you should/would).

[satotake]

I think I would expect the above to just silently drop the minify statement if I disable minify, that statement could well live in a theme I don't control.

You are right @bep . I failed to be careful for theme. I will fix

[bep]

This looks really good now, thanks a lot. I will pull this and apply some adjustments.

[bep]

I will complete this in #7077

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.