Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpl: Put Go's internal template funcs in Hugo's map #6718

Merged
merged 1 commit into from
Jan 7, 2020
Merged

tpl: Put Go's internal template funcs in Hugo's map #6718

merged 1 commit into from
Jan 7, 2020

Conversation

bep
Copy link
Member

@bep bep commented Jan 7, 2020 

name                            old time/op    new time/op    delta
SiteNew/Many_HTML_templates-16    43.4ms ± 0%    42.7ms ± 0%  -1.71%  (p=0.016 n=4+5)

name                            old alloc/op   new alloc/op   delta
SiteNew/Many_HTML_templates-16    17.5MB ± 0%    17.5MB ± 0%    ~     (p=0.690 n=5+5)

name                            old allocs/op  new allocs/op  delta
SiteNew/Many_HTML_templates-16      247k ± 0%      247k ± 0%    ~     (p=0.310 n=5+5)

Fixes #6717

@bep
Copy link
Member Author

bep commented Jan 7, 2020

Note that the benchmark above isn't the best. I see 10+% improvements building the Hugo site.

@bep bep force-pushed the template-func-locking branch from 681acd1 to 5dbb3c1 Compare January 7, 2020 12:17
@bep
tpl: Put Go's internal template funcs in Hugo's map
1cf2354 
```
name                            old time/op    new time/op    delta
SiteNew/Many_HTML_templates-16    43.4ms ± 0%    42.7ms ± 0%  -1.71%  (p=0.016 n=4+5)

name                            old alloc/op   new alloc/op   delta
SiteNew/Many_HTML_templates-16    17.5MB ± 0%    17.5MB ± 0%    ~     (p=0.690 n=5+5)

name                            old allocs/op  new allocs/op  delta
SiteNew/Many_HTML_templates-16      247k ± 0%      247k ± 0%    ~     (p=0.310 n=5+5)
```

Fixes gohugoio#6717
@bep bep force-pushed the template-func-locking branch from 5dbb3c1 to 1cf2354 Compare January 7, 2020 12:18
@bep bep merged commit 1cf2354 into gohugoio:master Jan 7, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lock latency Go's func map
1 participant
@bep