Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpl: Support GitInfo for content folders #6637

Closed
wants to merge 1 commit into from

Conversation

asafg6
Copy link

@asafg6 asafg6 commented Dec 19, 2019

Add an option to get git metadata from the content dir instead of the
working dir

Fixes #5533

@bep
Copy link
Member

bep commented Dec 22, 2019

He, and thanks for this.

While I do agree that we need something like this, using contentDir is too limiting. That setting still works, but it was replaced by the mounts slice recently. The way I see it we need to handle:

  • Multiple content directories
  • A way to detect if a content dir is a Git repo
  • A way to handle the special union mounts we have

@asafg6
Copy link
Author

asafg6 commented Dec 23, 2019

hi @bep
I didn't know about mounts :) I see that they allow a lot of flexibility around directory config. however i believe this setting will very much appeal more simple users like myself

@asafg6
Copy link
Author

asafg6 commented Jan 23, 2020

any chance of merging this?

@bep
Copy link
Member

bep commented Jan 27, 2020

any chance of merging this?

Not in the current state, no. See my comment above.

Add an option to get git metadata from the content dir instead of the
working dir

Fixes gohugoio#5533
@asafg6 asafg6 force-pushed the feature/gitinfo-content-dir branch from 5ea0dec to 9735069 Compare January 28, 2020 08:18
@asafg6
Copy link
Author

asafg6 commented Mar 19, 2020

any updates?

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@asafg6
Copy link
Author

asafg6 commented Apr 1, 2020

Anyone considering this?

@NorseGaud
Copy link

This is a huge need for us!

@deanishe
Copy link

deanishe commented Apr 13, 2020

I submitted a patch for this in 2018 (#5535) and it was ignored for over a year, then rejected in favour of a proposed feature that will fix the problem at some point in the future.

So I wouldn't hold your breath…

@asafg6
Copy link
Author

asafg6 commented Apr 19, 2020

@bep is there an alternative solution for that problem?

@deanishe
Copy link

@asafg6 my patch still works if you don't mind applying it and building Hugo yourself.

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Aug 16, 2020
@NorseGaud
Copy link

Bump

@stale stale bot removed the Stale label Aug 16, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Dec 19, 2020
@github-actions github-actions bot closed this Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GitInfo for content folders in different Git repositories
6 participants