hugolib: Cast taxonomy weight parameters to int #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushalmodi
suggested changes
Oct 3, 2018
hugolib/site.go
Outdated
|
|
||
| weight, err := cast.ToIntE(p.getParamToLower(plural + "_weight")) | ||
| if err != nil { | ||
| s.Log.ERROR.Print("unable to convert taxonomy weight to int") |
There was a problem hiding this comment.
Nitpick: Start message with upper case?
There was a problem hiding this comment.
Also print out the actual taxonomy weight (using %#v I think?) so that the user knows which exact taxonomy weight couldn't get casted.
Would it be possible to print the path of the offending file containing the uncastable taxonomy weight too?
Error is now "Unable to convert taxonomy weight []string{"40"} to int
for variables/files.md"
|
Has the Hacktoberfest started? I like it (note that you need to register somewhere to get the free t-shirt). |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4628