tpl: Ensure site templates can override theme templates #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we left some debugging code in place that caused all but one test case to run.
Add an additional test to "Variant 4, theme, use site base" to also test for the index.html base (from by testing of gohugoio#3505). Also add a "name" field to the test cases to make it easier to know which test is failing versus just getting a slice index.
The tplimpl package was misusing the TemplateLookupDescriptor.WorkingDir field from the output package. By incorrectly setting it to the theme directory instead of the site root, the user is unable to override theme templates in some situations. Fixes gohugoio#3505
|
@bep, |
Looks like my clever construct :-) Thanks. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tplimpl package was misusing the TemplateLookupDescriptor.WorkingDir
field from the output package. By incorrectly setting it to the theme
directory instead of the site root, the user is unable to override theme
templates in some situations.
Fixes #3505