Fix Docker build #4360
Merged
Fix Docker build #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The present Dockerfile in master does not build a Hugo container. The build container prematurely exits because `dep ensure` can not locate `Gopkg.toml` due to the source files not being copied/added to the container prior to running this command. The minimal change require to resolve the issue is merely move the ADD source before the RUN dep. Fixes #4076 Resolves #4077
|
While there are several PRs open for changes to fix and "improve" the Dockerfile the immediate concern should be to fix the existing code while improvements and changes to the file are undergoing consideration. |
|
Is Hugo planning to publish an image on Docker Hub? If so, is there a timeframe |
No. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present Dockerfile in master does not build a Hugo container. The
build container prematurely exits because
dep ensurecan not locateGopkg.tomldue to the source files not being copied/added to thecontainer prior to running this command. The minimal change require
to resolve the issue is merely move the ADD source before the RUN dep.
Fixes #4076
Resolves #4077