Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page metadata dates tests #4321

Closed
wants to merge 1 commit into from
Closed

Add page metadata dates tests #4321

wants to merge 1 commit into from

Conversation

vassudanagunta
Copy link
Contributor

@vassudanagunta vassudanagunta commented Jan 24, 2018

Adds combinatorial tests for the various kinds of dates in Page metadata. Provide:

Page.go was updated to use a different method to access a file's modification timestamp. This was necessary for the tests to work, but is a better way to access the value anyway.

@vassudanagunta
Copy link
Contributor Author

rebased on master

@bep
Copy link
Member

bep commented Jan 26, 2018

I assume this is a duplicate PR?

@vassudanagunta
Copy link
Contributor Author

The one you just merged was a child of this one, so GitHub includes the commit from this one in that one (the SHA remains the same). I set it up so you could merge this one first (since the commit is valuable and could stand on its own regardless of whether you accepted the child PR.

But now it is redundant. I guess GitHub doesn't try to figure that out.

@bep
Copy link
Member

bep commented Jan 26, 2018

The correct thing would be to cherry pick this commit into the other PR.

@vassudanagunta
Copy link
Contributor Author

That would take the commit from this PR branch and produce a new commit (new SHA) on the other PR's branch, whereas what I did was branch that PR off of the head of this one. Are you sure cherry picking would do something better?

@vassudanagunta vassudanagunta deleted the metadata-dates-tests branch January 27, 2018 05:51
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants