tpl: Add float template function #3921
Conversation
| @@ -30,6 +30,22 @@ type Namespace struct { | |||
|
|
|||
| // ToInt converts the given value to an int. | |||
| func (ns *Namespace) ToInt(v interface{}) (int, error) { | |||
| v = convertTemplateToString(v) | |||
There was a problem hiding this comment.
Please don't change exisiting methods. This doesn't look correct and I'm surprised there were not red tests.
There was a problem hiding this comment.
Please don't change exisiting methods
Why not? Should I just copy-and-paste the code that was used in toInt? I just took what was there before (the switch-case for the template types) and moved it into a separate helper function.
| v interface{} | ||
| expect interface{} | ||
| }{ | ||
| {"1", 1.0}, |
There was a problem hiding this comment.
These tests assumes that the input is strings only. I suspect your implementation will fail on 2, int64(2), float64(2) etc.
There was a problem hiding this comment.
I've pushed additional additional test cases, they all pass.
PS: Never mind me, there seems to be a difference between running make check and go test in that directory. Investigating
PPS: I just commited a typo, nvm
There was a problem hiding this comment.
Yea, I see now -- I read your original code slightly wrong, but it helped with the test cases.
x3ro
force-pushed
the
float-function
branch
from
e995f75 to
2ed01bf
Compare
Add a template function that allows conversion to float. This is useful, for example, when passing aspect ratios into templates, which tend to not be integers. Fixes gohugoio#3307
x3ro
force-pushed
the
float-function
branch
from
2ed01bf to
ef0463c
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Add a template function that allows conversion to float. This is
useful, for example, when passing aspect ratios into templates,
which tend to not be integers.
Fixes #3307
Feedback very welcome, this is the first time I've tampered with the hugo source 🎉