Simplify the Disqus template a little bit #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance to the official guide: https://disqus.com/admin/universal/
|
Thank you for your contribution, @yihui! The compact JavaScript code is better! :-) Though please do take a look of https://github.com/gohugoio/hugo/blob/master/CONTRIBUTING.md#git-commit-message-guidelines for improved commit message. For example,
would be better written as something like
Cheers! |
|
Okay, I'll improve the commit message next time. Thanks for the reminder! |
alanorth
added a commit
to alanorth/hugo-theme-bootstrap4-blog
that referenced
this pull request
Jul 7, 2017
Hugo 0.25 improved the embedded Disqus template so we can just use theirs now. See: gohugoio/hugo#3655 See: gohugoio/hugo#3639
bep
added a commit
that referenced
this pull request
Oct 19, 2017
e65df1059 Bump to v0.30 e9e118730 releaser: Prepare repository for 0.31-DEV e6f2508d4 releaser: Add release notes to /docs for release of 0.30 9c5d6a65b releaser: Bump versions for release of 0.30 88bf0e663 Merge commit 'ecf5e081b5540e69f4af330233f39a07baf53846' 6c7191331 Merge commit 'dae5a7c61cceeb0de59f2d755f63e453f71dd9b2' efd1821bd tpl: Add errorf template function 0cf8dc046 Change SummaryLength to be configurable (#3924) 9e8c09652 tpl: Add os.fileExists template function e969cfcd7 Merge commit '9d68f695e782c6a83c77aff13317c7a22c694c98' 1a2d516a0 tpl: Add float template function 5310162dc releaser: Prepare repository for 0.30-DEV 648fdf2d0 releaser: Add release notes to /docs for release of 0.29 b2f46992c releaser: Bump versions for release of 0.29 ec447e043 releaser: Prepare repository for 0.29-DEV 9f469e93a releaser: Add release notes to /docs for release of 0.28 c91c18ebc releaser: Bump versions for release of 0.28 253d2ede2 Merge commit '61c27b58b353c73772aae572c7d822fdfdf7791b' e35b93cc7 Merge commit '30694a133a88d5f76a51d0372646e10cbeca7691' 9fad59f66 Merge commit '7a89dce53bfbd67a17442a8f9be8fa895fc4f9b1' 4221c2855 Merge commit 'ba45da9d03056447e4873de13d4e0f8d658a769b' 0010b6743 releaser: Prepare repository for 0.28-DEV 9e71765cd releaser: Add release notes to /docs for release of 0.27.1 56206b90d releaser: Bump versions for release of 0.27.1 59522fca0 releaser: Prepare repository for 0.28-DEV 4686686d2 releaser: Add release notes to /docs for release of 0.27 0cd9a5d58 releaser: Bump versions for release of 0.27 d21a59d2d docs: Merge commit '1b4319be62ba071f79e90ef32dbe92eb893429f7' 9c4ff2d8e docs: Document Related Content 887fb1af7 docs: Merge commit '7d63a23b0c68d9cd7c7c09c2755619237bc03485' c8163b51b Update docs versiona and README f782c9959 Merge commit 'ec4e6f9df2ab9ffdc62a3f59675369096e0d3f77' as 'docs' d384c66 docs: Re-integrate 9a2eb0f Revert "Squashed 'docs/' changes from 35abbc86..f887bd7b" 0373e43 Squashed 'docs/' changes from 35abbc86..f887bd7b ea2cc26 Remove the theme submodule from /docs 0f9f73c Add support for multiple config files via --config a.toml,b.toml,c.toml c8257f8 Render task list item inside label for correct accessibility 0abdeee source: Normalize UniqueID between Windows & Linux e2f8664 hugolib: More spelling 46ac745 all: Fix spelling 4b54fb0 all: gofmt -s 40d7d3b releaser: Prepare repository for 0.27-DEV f090c27 releaser: Add release notes to /docs for release of 0.26 b36f6e3 releaser: Bump versions for release of 0.26 0f51e49 releaser: Add release notes draft for 0.26 62583db vendor: Update checksum for inflect 0d495d5 releaser: Update to new release notes location 22b213b Merge commit 'e81208265bb3cdb7606d051a23d83aeebcb7d34d' e812082 Squashed 'docs/' changes from ef02e34e..35abbc86 11e5d45 releaser: Include stats from hugoDocs f768c27 helpers: Remove some unused funcs 81c1317 Add some missing doc comments 9891c0f Remove sourceRelativeLinks 481924b helpers: Fix broken TaskList in Markdown 09907d3 Switch from fork bep/inflect to markbates/inflect 8fb594b Make the title case style guide configurable 9b4170c Remove unused dependencies from vendor.json 6acbe41 media: Add missing JSON tags to Type e321306 media: Add JSON tags to Type 9c19778 output: Add JSON tags to Format 50ec65f Squashed 'docs/' changes from 73f355ce..ef02e34e 1c18f3f Merge commit '50ec65fbe1a48475d3320775dab2c47389c02114' cb9dfc2 helpers: Add support for French Guillemets c4a0b6e vendor: Add support for French Guillemets a8080c0 Remove CODEOWNERS 84710eb Add -u flag for go get govendor in CONTRIBUTING.md 555a9bc tpl: Accommodate gccgo in TestMethodToName 55d0b89 tpl/collections: Fix intersect on []interface{} handling aee2b06 Add --debug option to be improved on over time c1a5da9 vendor: Update dependencies for 0.26-DEV 9ed48c1 Dockerfile: Run go install with -ldflags '-s -w' bfe0bfb Dockerfile: Reduce image size from 277MB to 27MB 606d6a8 Dockerfile: Optimize Docker image size 12e0495 docs: Add RSS template lookup example 6cd33f6 tpl: Use hash for cache key dbe6397 hugolib: Support reflinks starting with a slash 0c90e6d Change "hugodocs" to "hugoDocs" to match GitHub's default URL b60aa1a helpers: Add --trace to asciidoctor args ff433f9 Add script to pull in docs changes 2c0d1cc Squashed 'docs/' changes from b0470688..73f355ce f387cb1 doc: Merge commit '2c0d1ccdcd95de0bddeb39dca2e4d08f0d8056d7' 40566ec Remove ^M from file to make line-endings consistent 7759a98 Clarify the repo choice in the contribution guidelines 720786c Add note about doc-related pull requests in contribution guide 214e16e appveyor: Update submodules a2fb815 Add some README info about the docs repo 73273d4 Add the docs theme to .gitmodules 4c220c4 Merge commit '6dbde8d731f221b027c0c60b772ba82dad759943' 6dbde8d Squashed 'docs/' changes from f3c88b08..b0470688 deccc54 hubolib: Add HasShortcode 00b590d Improve the twitter card template ea5e9e3 Add GOEXE to support building with different versions of `go` 61bb3cc hugolib: Improve panic handling in layout rendering 794ea21 hugolib: Make template panics into nice error messages 91f410e Bump versions to 0.26-DEV 0e25f1e Revert "Revert "vendor: Update dependencies for 0.26-DEV"" aded65b releaser: Prepare repository for 0.25-DEV bbd33db releaser: Add release notes to /docs for release of 0.25.1 0e09be7 releaser: Bump versions for release of 0.25.1 195f945 releaser: Ignore openbsd/arm 44b8f74 releaser: Add release notes draft for 0.25.1 a48e132 Revert "vendor: Update dependencies for 0.26-DEV" 7f82b41 parser: Final (!) fix for issue with escaped JSON front matter 84db6c7 parser: Fix issue with escaped JSON front matter e0cf2e0 tpl/collections: Add some empty slice tests to intersect dbbc5c4 tpl/collections: Fix union when the first slice is empty 7bcc1ce commands: Navigate to changed on CREATE When working with content from IntelliJ IDE, like WebStorm, every file save is followed by two events: "RENAME" and then "CREATE". fd41e70 Add first draft of CODEOWNERS 4ec8ee7 vendor: Update dependencies for 0.26-DEV 1e19a98 releaser: Prepare repository for 0.26-DEV 6fb5563 releaser: Add release notes to /docs for release of 0.25 51bcd50 releaser: Fix tag push 6e086e3 releaser: Bump versions for release of 0.25 5895e32 releaser: Add release notes draft for 0.25 b2dcd86 Revert "vendor: Update dependencies" d2c24ba vendor: Update dependencies 4989950 releaser: Use real theme count in template a358b33 docs: Regenerate the docs helpers a392fca docs: Regenerate commands doc 75f782f Revert "commands: Adjust docs path" 37c6905 Squashed 'docs/' changes from 5d9a6703..f3c88b08 e00f5c9 docs: Merge docs commit '37c69054e294bf554be03cf7e4c01e1f586e6943' 4776840 releaser: Adjustments 70d8ddc releaser: Revise the docs handling to match new subtree 5f831a6 releaser: Replace the magic version handling e7a54e7 releaser: Add --try flag to ease testing aa6b1b9 output: Support templates per site/language a1d260b hugolib: Extend the sections API dd9b1ba hugolib: Make .Site.Sections return the top level sections 1039356 commands: Support human-readable YAML boolean values in undraft ccdd08d tpl/collections: Add Pages support to Intersect and Union d12cf5a tpl/collections: Fix In function for JSON arrays e10e51a parser: Fix handling of JSON front matter with escaped quotes 34c5667 tpl/math: Add log function 41805dc hugolib: Render 404.html for all languages 7ee1f25 hugo import jekyll support nested _posts directories 3aa0e16 cache: Add even more concurrency to test b3c8056 cache: Add concurrent cache test fe132e1 vendor: Add missing WebP dependencies 8431c8d tpl: Add WebP images support da72805 tpl: Only show post's own keywords in schema.org 72fd871 hugolib: Add more summary test 118f8f7 Dockerfile: Update Dockerfile and add Docker optimizations 56d82aa hugofs: Fix typo in code comment eccb064 tpl: Simplify the Disqus template a little bit (#3655) 2e1e493 tpl: Improve the built-in Disqus template (#3639) a544049 helpers: Add Blackfriday 'joinLines' extension support (#3574) bfce30d helpers: add --initial-header-level=2 to rst2html (#3528) 30e14cc Make `--navigateToChanged` more robust on Windows c825a73 Support open "current content page" in browser 7198ea8 Revert "Remove docs building from CI builds" dd78d5b Squashed 'docs/' content from commit 5d9a6703 a7765bb Merge commit 'dd78d5b23fe597f4461aa4199401b4e07c0612e2' as 'docs' git-subtree-dir: docs git-subtree-split: e65df1059549d951a45853576374be4088ded1d3
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance to the official guide: https://disqus.com/admin/universal/