Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the built-in Disqus template #3639

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Improve the built-in Disqus template #3639

merged 2 commits into from
Jun 27, 2017

Commits on Jun 23, 2017

  1. Improve the built-in Disqus template 

    Set `disqus_identifier`, `disqus_title`, and `disqus_url` only if the user has explicitly provided them.

Do not load Disqus when the website is previewed locally, otherwise it is very confusing.
    @yihui
    yihui authored Jun 23, 2017
    Configuration menu
    Copy the full SHA
    a55642d View commit details
    Browse the repository at this point in the history

  2. Use disqus_config instead of three global variables 

    https://help.disqus.com/customer/portal/articles/472098-javascript-configuration-variables
    @yihui
    yihui authored Jun 23, 2017
    Configuration menu
    Copy the full SHA
    577286d View commit details
    Browse the repository at this point in the history