Fix taxonomy titles #1184
Closed
Fix taxonomy titles #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the taxonomy `Gérard Depardieu` gives paths on the form `gerard-depardieu`. Unfortunately this introduces two imports from the `golang.org/`, but Unicode-normalization isn't something we'd want to write from scratch. See https://blog.golang.org/normalization See gohugoio#1180
Before this commit, taxonomy names were hyphenated, lower-cased and normalized -- then fixed and titleized on the archive page. So what you entered in the front matter isn't necessarily what you got in the final site. To preserve backwards compability, `PreserveTaxonomyNames` is default `false`. Setting it to `true` will preserve what you type (the first characters is made toupper for titles), but normalized in URLs. This also means that, if you manually construct URLs to the archive pages, you will have to pass the Taxonomy names through the `urlize` func. Fixes gohugoio#1180
|
I can't try it right now but if I understand the commit message, it's exactly what I needed. "Gérard Depardieu" in the post metadata so, Right ? If so, I don't understand why you would not be happy. :-) |
|
Yea, it's exactly what you want ... but the implementation could be cleaner if I didn't have to worry about breaking some sites. |
|
Merged in be38acd |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
This is an issue that has been nagging me for a while.
I'm not totally happy about this fix. I would ideally just have added the full taxonomy name to the taxonomy entry, but I get dizzy thinking about just the documentation changes needed.
If someone knows about a "rangeable struct" that can take additional fields I would be happy to throw out some of this code.
/cc @spf13 @tatsushid @nicolinuxfr
Fixes #1180