Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpl/collections: Fix append when appending a slice to a slice of slices #11093

Closed
wants to merge 1 commit into from
Closed

tpl/collections: Fix append when appending a slice to a slice of slices #11093

wants to merge 1 commit into from

Conversation

bep
Copy link
Member

@bep bep commented Jun 13, 2023

Fixes #11004

@bep bep force-pushed the fix/append-11004 branch from deb3eaa to 4d22ba2 Compare June 13, 2023 09:17
@bep bep requested a review from jmooring June 13, 2023 15:54
jmooring
jmooring reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hugo v0.114.0-DEV-4d22ba2

This:

{{ $obj := slice (slice "a") }}
{{ $obj = $obj | append (slice "b") }}
{{ $obj = $obj | append (slice "c") }}

<pre>
{{ jsonify (dict "indent" "  ") $obj }}
</pre>

Still produces this:

[
  [
    "a"
  ],
  "b",
  [
    "c"
  ]
]

@bep
Copy link
Member Author

bep commented Jun 13, 2023

Hmm...

@bep
Copy link
Member Author

bep commented Jun 14, 2023

I'm going to take one more stab at this, but I need to start fresh.

@bep bep closed this Jun 14, 2023
bep added a commit to bep/hugo that referenced this pull request Jun 14, 2023
@bep
tpl/collections: Fix append when appending a slice to a slice of slices
666950d 
Fixes gohugoio#11093
bep added a commit to bep/hugo that referenced this pull request Jun 14, 2023
@bep
tpl/collections: Fix append when appending a slice to a slice of slices
285687f 
Fixes gohugoio#11093
bep added a commit to bep/hugo that referenced this pull request Jun 14, 2023
@bep
tpl/collections: Fix append when appending a slice to a slice of slices
cefe74d 
Fixes gohugoio#11093
bep added a commit that referenced this pull request Jun 14, 2023
@bep
tpl/collections: Fix append when appending a slice to a slice of slices
d178fe9 
Fixes #11093
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmooring jmooring jmooring left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected result appending a slice to a slice of slices
2 participants
@bep @jmooring