Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make markdownify work as site.Home.RenderString #9538

Closed
bep opened this issue Feb 21, 2022 · 1 comment · Fixed by #9544
Closed

Make markdownify work as site.Home.RenderString #9538

bep opened this issue Feb 21, 2022 · 1 comment · Fixed by #9544
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.93.0

Comments

@bep
Copy link
Member

bep commented Feb 21, 2022 •
edited
Loading

While working on #9521 (basically render hook support for code blocks), I had to simplify the hook code (mainly to get support for a template per code language). This lead me to the simplification that I'm surprised I didn't think about the first time around: By making markdownify just a delegate for site.Home.RenderString I can remove a lot of superfluous code. And it it also removes some of the limitations of markdownify, mainly that render hooks now just works.

I will consider if we want/need to go the extra mile to be called from the "current page" and not always the home page (which probably be better template wise).

I'm assuming that this is all a good thing, but I'm creating this issue to track it.

/cc @jmooring
@bep bep added this to the v0.93.0 milestone Feb 21, 2022
@bep bep self-assigned this Feb 21, 2022
@bep bep mentioned this issue Feb 22, 2022
Merged
bep added a commit to bep/hugo that referenced this issue Feb 22, 2022
@bep
Add render hooks for cdeblocks + Goat and Mermaid diagrams
2691182 
Updates gohugoio#7765
Closes gohugoio#9538
bep added a commit to bep/hugo that referenced this issue Feb 22, 2022
@bep
Add render hooks for cdeblocks + Goat and Mermaid diagrams
bbcd7d3 
Updates gohugoio#7765
Closes gohugoio#9538
bep added a commit to bep/hugo that referenced this issue Feb 22, 2022
@bep
Add render hooks for cdeblocks + Goat and Mermaid diagrams
80bc465 
Updates gohugoio#7765
Closes gohugoio#9538
bep added a commit to bep/hugo that referenced this issue Feb 22, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
e6f3955 
Updates gohugoio#7765
Closes gohugoio#9538
bep added a commit to bep/hugo that referenced this issue Feb 22, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
346da9a 
Updates gohugoio#7765
Closes gohugoio#9538
bep added a commit to bep/hugo that referenced this issue Feb 22, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
8c66f6d 
Updates gohugoio#7765
Closes gohugoio#9538
bep added a commit to bep/hugo that referenced this issue Feb 23, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
4da5711 
Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
bep added a commit to bep/hugo that referenced this issue Feb 23, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
4aaf0b2 
Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
bep added a commit to bep/hugo that referenced this issue Feb 23, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
9e9188e 
Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
bep added a commit to bep/hugo that referenced this issue Feb 23, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
b624b5b 
Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
bep added a commit to bep/hugo that referenced this issue Feb 23, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
a4df994 
Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
Fixes gohugoio#8520
Fixes gohugoio#6702
bep added a commit to bep/hugo that referenced this issue Feb 23, 2022
@bep
Add render hooks for codeblocks + Goat and Mermaid diagrams
f966ca1 
Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
Fixes gohugoio#8520
Fixes gohugoio#6702
bep added a commit to bep/hugo that referenced this issue Feb 24, 2022
@bep
Add Markdown diagrams and render hooks for code blocks
45d81db 
You can now create custom hook templates for code blocks, either one for all (`render-codeblock.html`) or for a given code language (e.g. `render-codeblock-go.html`).

We also used this new hook to add support for diagrams in Hugo:

* Goat (Go ASCII Tool) is built-in and enabled by default; just create a fenced code block with the language `goat` and start draw your Ascii diagrams.
* Another popular alternative for diagrams in Markdown, Mermaid (supported by GitHub), can also be implemented with a simple template. See the Hugo documentation for more information.

Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
Fixes gohugoio#8520
Fixes gohugoio#6702
Fixes gohugoio#9558
bep added a commit to bep/hugo that referenced this issue Feb 24, 2022
@bep
Add Markdown diagrams and render hooks for code blocks
c047af9 
You can now create custom hook templates for code blocks, either one for all (`render-codeblock.html`) or for a given code language (e.g. `render-codeblock-go.html`).

We also used this new hook to add support for diagrams in Hugo:

* Goat (Go ASCII Tool) is built-in and enabled by default; just create a fenced code block with the language `goat` and start draw your Ascii diagrams.
* Another popular alternative for diagrams in Markdown, Mermaid (supported by GitHub), can also be implemented with a simple template. See the Hugo documentation for more information.

Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
Fixes gohugoio#8520
Fixes gohugoio#6702
Fixes gohugoio#9558
bep added a commit to bep/hugo that referenced this issue Feb 24, 2022
@bep
Add Markdown diagrams and render hooks for code blocks
6a57a11 
You can now create custom hook templates for code blocks, either one for all (`render-codeblock.html`) or for a given code language (e.g. `render-codeblock-go.html`).

We also used this new hook to add support for diagrams in Hugo:

* Goat (Go ASCII Tool) is built-in and enabled by default; just create a fenced code block with the language `goat` and start draw your Ascii diagrams.
* Another popular alternative for diagrams in Markdown, Mermaid (supported by GitHub), can also be implemented with a simple template. See the Hugo documentation for more information.

Updates gohugoio#7765
Closes gohugoio#9538
Fixes gohugoio#9553
Fixes gohugoio#8520
Fixes gohugoio#6702
Fixes gohugoio#9558
@bep bep closed this as completed in #9544 Feb 24, 2022
bep added a commit that referenced this issue Feb 24, 2022
@bep
Add Markdown diagrams and render hooks for code blocks
08fdca9 
You can now create custom hook templates for code blocks, either one for all (`render-codeblock.html`) or for a given code language (e.g. `render-codeblock-go.html`).

We also used this new hook to add support for diagrams in Hugo:

* Goat (Go ASCII Tool) is built-in and enabled by default; just create a fenced code block with the language `goat` and start draw your Ascii diagrams.
* Another popular alternative for diagrams in Markdown, Mermaid (supported by GitHub), can also be implemented with a simple template. See the Hugo documentation for more information.

Updates #7765
Closes #9538
Fixes #9553
Fixes #8520
Fixes #6702
Fixes #9558
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.93.0
Development

Successfully merging a pull request may close this issue.

Add render hooks for codeblocks + Goat and Mermaid diagrams bep/hugo
1 participant
@bep