Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or optimize issues workflow script #9522

Closed
davidsneighbour opened this issue Feb 18, 2022 · 5 comments
Closed

Fix or optimize issues workflow script #9522

davidsneighbour opened this issue Feb 18, 2022 · 5 comments

Comments

@davidsneighbour
Copy link
Contributor

The workflow script for issues is suboptimal. I can say that without "probably" because the behaviour I am experiencing is, that every day in the morning (UTC+7) exactly 100 issues get locked/marked stale by the bot. Not more or less. This points to some form of limit. I was thinking to let it run its course and that the bot might someday be finished with all legacy issues, but then again, this is going on for weeks now. I think there might be a deeper issue.

Proposal 1: add manually workflow definition so the workflow can be run manually (if the issues touched per workflow run are limited somehow)

Proposal 2: optmise the setup:

          issue-inactive-days: 7

In my opinion, this is the culprit, because the note of the bot that this issue is stale is an activity and this basically leaves us with 700 issues max before an already stale issue is admonished again. Set this to either something higher (30) or in combination with Proposal 3 to something like 10 or even higher

Proposal 3: close issues that are stale.

          days-before-issue-stale: 600
          days-before-pr-stale: 200
          days-before-issue-close: -1
          days-before-pr-close: -1

This lets the bot NEVER close issues that are stale, which leads to the weird behaviour described above. Let's set that to 7, so those issues can be closed. Also, the issue-stale and pr-stale days look very large to me. An issue is marked inactive after 7 days, but stale after 600 days?

Worst case scenario is that "disgruntled" developers and issue openers will complain about "their" issue being closed, but we can always say, that this is a hygienic way to keep the project management clean.

I somehow feel like the overall setup should be along the lines of something like this:

issue-inactive-days: x days
days-before-issue-stale: x + 1/2 x days
days-before-issue-close: 1/2 x - 1 days

Sample: An issue is inactive after 30 days, stale after 45 and gets closed on day 59 or 60.

@davidsneighbour
Copy link
Contributor Author

I forgot to mention the manual workflow run:

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch

With this marker the workflow could be run manually and the maintainer can run the workflow over all issues once and then we are back to normal behaviour and not exactly 100 changes daily.

bep added a commit that referenced this issue Feb 18, 2022
bep added a commit that referenced this issue Feb 18, 2022
@bep
Copy link
Member

bep commented Feb 18, 2022

Yea, I have probably missed a lots of real notifications because of this ... I just assumed that it was going to end one day.

@bep
Copy link
Member

bep commented Feb 18, 2022

But looking in the log:

image

bep added a commit that referenced this issue Feb 18, 2022
@bep bep modified the milestones: v0.95.0, v0.96.0 Mar 9, 2022
@bep bep modified the milestones: v0.96.0, v0.97.0 Mar 24, 2022
@bep bep modified the milestones: v0.97.0, v0.98.0 Apr 13, 2022
@bep bep modified the milestones: v0.98.0, v0.99.0 Apr 28, 2022
@bep bep modified the milestones: v0.99.0, v0.100.0 May 24, 2022
@bep bep modified the milestones: v0.100.0, v0.101.0 May 31, 2022
@bep bep modified the milestones: v0.101.0, v0.102.0 Jun 16, 2022
@bep bep modified the milestones: v0.102.0, v0.103.0 Aug 28, 2022
@bep bep modified the milestones: v0.103.0, v0.104.0 Sep 15, 2022
@bep bep modified the milestones: v0.104.0, v0.105.0 Sep 23, 2022
@bep bep modified the milestones: v0.105.0, v0.106.0 Oct 26, 2022
@bep bep modified the milestones: v0.106.0, v0.107.0 Nov 18, 2022
@bep bep modified the milestones: v0.107.0, v0.108.0 Dec 3, 2022
@bep bep modified the milestones: v0.108.0, v0.109.0 Dec 14, 2022
@bep bep modified the milestones: v0.109.0, v0.111.0, v0.110.0 Jan 26, 2023
@bep bep modified the milestones: v0.111.0, v0.112.0 Feb 15, 2023
@bep bep modified the milestones: v0.112.0, v0.113.0 Apr 15, 2023
@jmooring
Copy link
Member

@davidsneighbour

every day in the morning (UTC+7) exactly 100 issues get locked/marked stale by the bot.

At this point the legacy issues have been processed by the updated workflow.

Is it OK to close this issue now?

@bep bep closed this as completed May 19, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants