Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude event attributes from markdown render hook #9511

Closed
jmooring opened this issue Feb 16, 2022 · 1 comment · Fixed by #9512
Closed

Exclude event attributes from markdown render hook #9511

jmooring opened this issue Feb 16, 2022 · 1 comment · Fixed by #9512
Assignees
@jmooring
Labels
Bug Outdated

Comments

@jmooring
Copy link
Member

The fix for #9463 (PR #9464) neglected to consider markdown render hooks, specifically render-heading.

<h{{ .Level }}
  {{- range $k, $v := .Attributes -}}
    {{- printf " %s=%q" $k $v | safeHTMLAttr -}}
  {{- end -}}
>{{ .Text | safeHTML }}</h{{ .Level }}>
@jmooring jmooring self-assigned this Feb 16, 2022
jmooring added a commit to jmooring/hugo that referenced this issue Feb 16, 2022
@jmooring
Exclude event attributes from markdown render hook
13e51c6 
Fixes gohugoio#9511
@jmooring jmooring mentioned this issue Feb 16, 2022
Merged
@bep bep closed this as completed in #9512 Feb 16, 2022
bep pushed a commit that referenced this issue Feb 16, 2022
@jmooring
markup/goldmark: Exclude event attributes from markdown render hook
ff545f4 
Fixes #9511
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Bug Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude event attributes from markdown render hook jmooring/hugo
1 participant
@jmooring