Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.17 #8930

Closed
bep opened this issue Aug 26, 2021 · 2 comments · Fixed by #8932
Closed

Update to Go 1.17 #8930

bep opened this issue Aug 26, 2021 · 2 comments · Fixed by #8932
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.88

Comments

@bep
Copy link
Member

bep commented Aug 26, 2021

And remember the Go templates package.
@bep bep self-assigned this Aug 26, 2021
@bep bep added this to the v0.88 milestone Aug 26, 2021
@bep
Copy link
Member Author

bep commented Aug 26, 2021

And remember the Go templates package.

Never mind, that needs to wait until Go 1.18 (they have started to use Go 1.17 API, and there isn't anything in Go 1.17 in these packages that ver really need).

bep added a commit to bep/hugo that referenced this issue Aug 26, 2021
@bep
Update to Go 1.17
0466f11 
Fixes gohugoio#8930
@bep bep mentioned this issue Aug 26, 2021
Merged
bep added a commit to bep/hugo that referenced this issue Aug 30, 2021
@bep
Update to Go 1.17
fa29d18 
Fixes gohugoio#8930
bep added a commit to bep/hugo that referenced this issue Aug 31, 2021
@bep
Update to Go 1.17
903f846 
Go 1.17 now lazy-loads dependencies when `go.mod` is version `go17`. This does not work for us for new projects started with `hugo mod init`.

Before this commit, starting a project with Go 1.17 with `hugo mod init` and then start adding dependencies with transitive dependenies to `config.toml` would treat the transitive dependencies as new, and you would potentially get a too recent version of those.

Note that this does not effect existing projects, where all dependencies are already recorded in `go.mod`.

Fixes gohugoio#8930
bep added a commit to bep/hugo that referenced this issue Aug 31, 2021
@bep
Update to Go 1.17
2a829be 
Go 1.17 now lazy-loads dependencies when `go.mod` is version `go17`. This does not work for us for new projects started with `hugo mod init`.

Before this commit, starting a project with Go 1.17 with `hugo mod init` and then start adding dependencies with transitive dependenies to `config.toml` would treat the transitive dependencies as new, and you would potentially get a too recent version of those.

Note that this does not effect existing projects, where all dependencies are already recorded in `go.mod`.

Fixes gohugoio#8930
@bep bep closed this as completed in 0fc2ce9 Aug 31, 2021
@bot-actions bot-actions bot mentioned this issue Sep 3, 2021
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.88
Development

Successfully merging a pull request may close this issue.

Update to Go 1.17 bep/hugo
1 participant
@bep