Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minify to fix ES6 corruption issue. #8831

Closed
bwklein opened this issue Jul 30, 2021 · 3 comments · Fixed by #8840
Closed

Upgrade minify to fix ES6 corruption issue. #8831

bwklein opened this issue Jul 30, 2021 · 3 comments · Fixed by #8840
Labels
Milestone

Comments

@bwklein
Copy link
Contributor

bwklein commented Jul 30, 2021

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.83.1-5AFE0A57+extended linux/amd64 BuildDate=2021-05-02T14:38:05Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?

Requires an update of tdewolff/minify to a version released after 2021-07-29.
tdewolff/minify@9f73f9d

Problem

There was a regression in the minify library that corrupted ES6 format code in <script> tags.
tdewolff/minify#429
This has been resolved, and Hugo just needs to pull in the latest version of the library.

@bep bep modified the milestones: v0.88, v0.87 Jul 30, 2021
@bep
Copy link
Member

bep commented Aug 1, 2021

This has been resolved, and Hugo just needs to pull in the latest version of the library.

There is no version with this patch as far as I can see. Can you ask upstream for a new tagged version?

@bwklein
Copy link
Contributor Author

bwklein commented Aug 1, 2021

I've made the request.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants