Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal schema templates display + instead of + for dates with positive offsets #8671

Closed
jmooring opened this issue Jun 19, 2021 · 2 comments · Fixed by #8678
Closed

Internal schema templates display + instead of + for dates with positive offsets #8671

jmooring opened this issue Jun 19, 2021 · 2 comments · Fixed by #8678
Assignees
@jmooring
Labels
Bug Feature: Embedded Template Outdated

Comments

@jmooring
Copy link
Member

These were fixed with #5887 and #7495, then broken again with #8256.

PR to follow...
@jmooring jmooring self-assigned this Jun 19, 2021
@jmooring jmooring changed the title Internal schema templates displays + instead of + for dates with positive offsets Internal schema templates display + instead of + for dates with positive offsets Jun 19, 2021
@jmooring
Copy link
Member Author

jmooring commented Jun 19, 2021 •
edited
Loading

TODO:

  • Add tests to make sure this isn't broken again in the future

@jmooring jmooring mentioned this issue Jun 20, 2021
Merged
@bep bep closed this as completed in #8678 Jun 29, 2021
bep pushed a commit that referenced this issue Jun 29, 2021
@jmooring @bep
Fix date format in schema and opengraph templates
34e4742 
Fixes #8671
@bot-actions bot-actions bot mentioned this issue Jul 2, 2021
Merged
This was referenced Jul 5, 2021
Merged
Merged
@bot-actions bot-actions bot mentioned this issue Jul 7, 2021
Merged
@github-actions github-actions bot mentioned this issue Jul 16, 2021
Closed
This was referenced Jul 16, 2021
Closed
Closed
@github-actions github-actions bot mentioned this issue Jul 16, 2021
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Bug Feature: Embedded Template Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix date format in schema and opengraph templates
1 participant
@jmooring