Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lastmod in Org Mode timestamp formats #8536

Closed
pprevos opened this issue May 15, 2021 · 5 comments · Fixed by #10800
Closed

Support for lastmod in Org Mode timestamp formats #8536

pprevos opened this issue May 15, 2021 · 5 comments · Fixed by #10800

Comments

@pprevos
Copy link

pprevos commented May 15, 2021

I am using hugo v0.83.1+extended linux/amd64 BuildDate=unknown

Org Mode uses a timestamp format that is only partially

In issue 7433, Hugo was modified so that it could parse Org timestamps in the .Date variable.

This does not seem to work when using the lastmod variable.

Example:

#+lastmod: 2021-05-15

Renders as expected.

#+lastmod: <2021-05-15 Sat> or #+lastmod: [2021-05-15 Sat] does not render as the .Lastmod parameter defaults to the .Date variable.

Would it be possible to have Hugo recognise Org Mode timestamps for all frontmatter date formats?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the Stale label May 16, 2022
@bep bep added this to the v0.99.0 milestone May 16, 2022
@bep
Copy link
Member

bep commented May 16, 2022

Sorry for the late response, yes, we should fix this. I suggest adding lastmod, publishdate and expirydate to that list.

@pprevos
Copy link
Author

pprevos commented May 16, 2022

Thanks!

My workaround is to use plain text (2029-05-16), but using Org mode ([2029-05-16]) dates is neater because it offers other Emacs functionality.

@bep bep modified the milestones: v0.99.0, v0.100.0 May 24, 2022
@bep bep modified the milestones: v0.100.0, v0.101.0 May 31, 2022
@bep bep modified the milestones: v0.101.0, v0.102.0 Jun 16, 2022
@bep bep modified the milestones: v0.102.0, v0.103.0 Aug 28, 2022
@bep bep modified the milestones: v0.103.0, v0.104.0 Sep 15, 2022
@bep bep modified the milestones: v0.104.0, v0.105.0 Sep 23, 2022
@bep bep modified the milestones: v0.105.0, v0.106.0 Oct 26, 2022
@bep bep modified the milestones: v0.106.0, v0.107.0 Nov 18, 2022
@bep bep modified the milestones: v0.107.0, v0.108.0 Dec 3, 2022
@bep bep modified the milestones: v0.108.0, v0.109.0 Dec 14, 2022
@bep bep modified the milestones: v0.109.0, v0.111.0, v0.110.0 Jan 26, 2023
@bep bep modified the milestones: v0.111.0, v0.112.0 Feb 15, 2023
johannesengl added a commit to johannesengl/hugo that referenced this issue Mar 6, 2023
PR gohugoio#7433 added support for Org timestamps for the DATE header. This PR widens the support with additional front matter headers LASTMOD, PUBLISHDATE and EXPIRYDATE.

Fixes gohugoio#8536
@johannesengl
Copy link
Contributor

@bep Created a PR for this. Would appreciate a review :)

@bep bep closed this as completed in #10800 Mar 6, 2023
bep pushed a commit that referenced this issue Mar 6, 2023
PR #7433 added support for Org timestamps for the DATE header. This PR widens the support with additional front matter headers LASTMOD, PUBLISHDATE and EXPIRYDATE.

Fixes #8536
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants