Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new embed package to embed the buit-in Hugo templates #8297

Closed
bep opened this issue Mar 3, 2021 · 7 comments · Fixed by #9481
Closed

Use the new embed package to embed the buit-in Hugo templates #8297

bep opened this issue Mar 3, 2021 · 7 comments · Fixed by #9481

Comments

@bep
Copy link
Member

bep commented Mar 3, 2021

https://golang.org/doc/go1.16#library-embed

Would replace this script:

https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/embedded/generate/generate.go

@bep bep added this to the v0.82 milestone Mar 3, 2021
@shimst3r
Copy link

shimst3r commented Mar 5, 2021

@bep may I take a look at this? I'd really like to give back to the Hugo community and this looks like a doable feature for me. 😄

@bep
Copy link
Member Author

bep commented Mar 5, 2021

@shimst3r great! Shout if you have any questions.

@shimst3r
Copy link

shimst3r commented Mar 7, 2021

@bep great 😄

Just to make sure I've got this right: This is going to be a "drop-in" replacement for existing functionality, so my objective would be to make the tests in hugo/hugolib/embedded_templates_test.go pass using pkg/embed?

@bep
Copy link
Member Author

bep commented Mar 7, 2021

so my objective would be to make the tests in hugo/hugolib/embedded_templates_test.go pass using pkg/embed?

Yes.

@shimst3r
Copy link

shimst3r commented Mar 7, 2021

Thanks a lot for your quick answer. 🙇

@shimst3r
Copy link

@bep I've opened a merge request. Hopefully I didn't commit too many Go sins at once. 😅

@bep bep modified the milestones: v0.82, v0.83 Mar 21, 2021
@bep bep modified the milestones: v0.83, v0.84 May 1, 2021
@bep bep modified the milestones: v0.84, v0.85 Jun 18, 2021
@bep bep modified the milestones: v0.85, v0.86 Jul 5, 2021
@bep bep modified the milestones: v0.86, v0.87, v0.88 Jul 26, 2021
@bep bep modified the milestones: v0.88, v0.89 Sep 2, 2021
@bep bep modified the milestones: v0.89, v0.90 Nov 2, 2021
@bep bep modified the milestones: v0.90, v0.91.0 Dec 13, 2021
@bep bep modified the milestones: v0.91.0, v0.92.0 Dec 22, 2021
@bep bep modified the milestones: v0.92.0, v0.93.0 Jan 12, 2022
bep added a commit to bep/hugo that referenced this issue Feb 9, 2022
bep added a commit to bep/hugo that referenced this issue Feb 9, 2022
bep added a commit to bep/hugo that referenced this issue Feb 9, 2022
bep added a commit to bep/hugo that referenced this issue Feb 9, 2022
bep added a commit to bep/hugo that referenced this issue Feb 10, 2022
bep added a commit to bep/hugo that referenced this issue Feb 10, 2022
@bep bep closed this as completed in #9481 Feb 14, 2022
bep added a commit that referenced this issue Feb 14, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants