Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modules.vendorClosest #8235

Closed
bep opened this issue Feb 14, 2021 · 1 comment · Fixed by #8238
Closed

Add modules.vendorClosest #8235

bep opened this issue Feb 14, 2021 · 1 comment · Fixed by #8238
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.81

Comments

@bep
Copy link
Member

bep commented Feb 14, 2021

Given this:

mainProject
   _vendor
   submodule
       _vendor

If a dependency used by submodule exists in mainProject._vendor, then that is the version that is used.

The use case I have in mind may be exotic, but this new flag would pick the vendored dependency closest to where it's used and not the first one, as it is now.

Note that there can still be only one dependency of a given module path, so if mainProject is also using this dependency, then that _vendor version will win.
@bep bep added this to the v0.81 milestone Feb 14, 2021
@bep bep self-assigned this Feb 14, 2021
bep added a commit to bep/hugo that referenced this issue Feb 14, 2021
@bep
modules: Add config option modules.vendorClosest
05ff128 
Fixes gohugoio#8235
@bep bep mentioned this issue Feb 14, 2021
Merged
bep added a commit to bep/hugo that referenced this issue Feb 16, 2021
@bep
modules: Add config option modules.vendorClosest
f0565e3 
Fixes gohugoio#8235
Fixes gohugoio#8242
@bep bep closed this as completed in #8238 Feb 16, 2021
bep added a commit that referenced this issue Feb 16, 2021
@bep
modules: Add config option modules.vendorClosest
bdfbcf6 
Fixes #8235
Fixes #8242
@bot-actions bot-actions bot mentioned this issue Feb 22, 2021
Merged
@fmotrifork fmotrifork mentioned this issue Feb 22, 2021
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.81
Development

Successfully merging a pull request may close this issue.

modules: Add config option modules.vendorClosest bep/hugo
1 participant
@bep