Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module path="../somefolder" should not mean relative to themesDir #7906

Closed
bep opened this issue Oct 29, 2020 · 2 comments
Closed

Module path="../somefolder" should not mean relative to themesDir #7906

bep opened this issue Oct 29, 2020 · 2 comments
Assignees
@bep
Labels
Enhancement Outdated

Comments

@bep
Copy link
Member

bep commented Oct 29, 2020 •
edited
Loading

I will not label this a bug, but this caught me by surprise.

So:

 path=".hyde"

Will look in the themes folder.

But:

 path=".."

Need to use "one level up" as the theme.
@bep bep self-assigned this Oct 29, 2020
bep added a commit to bep/hugo that referenced this issue Oct 29, 2020
@bep
Add module.replacements
af0455f 
Fixes gohugoio#7904
Fixes gohugoio#7906
bep added a commit to bep/hugo that referenced this issue Oct 29, 2020
@bep
Add module.replacements
cf03405 
Fixes gohugoio#7904
Fixes gohugoio#7906
bep added a commit to bep/hugo that referenced this issue Oct 29, 2020
@bep
Add module.replacements
46eaa25 
Fixes gohugoio#7904
Fixes gohugoio#7906
bep added a commit to bep/hugo that referenced this issue Oct 30, 2020
@bep
Add module.replacements
33e4dad 
Fixes gohugoio#7904
Fixes gohugoio#7906
@bep
Copy link
Member Author

bep commented Oct 30, 2020

No, thinking a little about this, I will reject my own idea, as:

  • However unlikely, this is a breaking change
  • Also, it's better to have 1 rule for all relative paths, even if it looks a little off when you look at it.

@bep bep closed this as completed Oct 30, 2020
@bep bep mentioned this issue Oct 30, 2020
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bep