Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to set HUGO_MODULE_PROXY via OS env (but can replace) #7903

Closed
bep opened this issue Oct 29, 2020 · 2 comments
Closed

Not possible to set HUGO_MODULE_PROXY via OS env (but can replace) #7903

bep opened this issue Oct 29, 2020 · 2 comments
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.76.6

Comments

@bep
Copy link
Member

bep commented Oct 29, 2020

E.g.:

env HUGO_MODULE_PROXY=https://proxy.example.org hugo

There seem to be a off-by one error in that logic.
@bep bep self-assigned this Oct 29, 2020
@bep bep added the Bug label Oct 29, 2020
@bep bep added this to the v0.76.6 milestone Oct 29, 2020
@bep
Copy link
Member Author

bep commented Oct 29, 2020

OK, the above only fails if there is no proxy set in config. The workaround is to always set the default value:

[module]
proxy="direct"

@bep bep modified the milestones: v0.76.6, v0.77 Oct 29, 2020
@bep bep changed the title Not possible to set HUGO_MODULE_PROXY via Os env Not possible to set HUGO_MODULE_PROXY via OS env (but can replace) Oct 29, 2020
bep added a commit to bep/hugo that referenced this issue Oct 29, 2020
@bep
Fix setting HUGO_MODULE_PROXY etc. via env vars
68ccbe7 
Fixes gohugoio#7903
@bep bep closed this as completed in 8a1c637 Oct 30, 2020
@bot-actions bot-actions bot mentioned this issue Nov 1, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Nov 2, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.76.6
Development

No branches or pull requests
1 participant
@bep