Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build tags to not compile-in 'hugo deploy' cloud SDKs #7826

Closed
fazalmajid opened this issue Oct 13, 2020 · 6 comments · Fixed by #7868
Closed

Build tags to not compile-in 'hugo deploy' cloud SDKs #7826

fazalmajid opened this issue Oct 13, 2020 · 6 comments · Fixed by #7868
Labels
Enhancement Outdated
Milestone
v0.76.5

Comments

@fazalmajid
Copy link
Contributor

hugo deploy is convenient but pulls in many dependencies and cloud SDKs that can break on certain platforms (#6324) and generally increase the compilation time and size of the executable.

It would be nice to have a a negative build tag nodeploy so that functionality could be omitted by building using go install --tags nodeploy
@bep bep added Enhancement and removed Proposal labels Oct 14, 2020
@bep bep added this to the v0.76.5 milestone Oct 14, 2020
@emhagman
Copy link
Contributor

Could I tackle this?

@fazalmajid
Copy link
Contributor Author

@emhagman be my guest, I just didn't want to impose on bep's time.

@bep
Copy link
Member

bep commented Oct 21, 2020

Could I tackle this?

Please do.

@emhagman
Copy link
Contributor

emhagman commented Oct 21, 2020 •
edited
Loading

Could I tackle this?

Please do.

Great, thanks 👍

@emhagman emhagman mentioned this issue Oct 21, 2020
Merged
@emhagman
Copy link
Contributor

#7868 took a stab at it. Let me know if you'd like me to remove the command all together or have hugo deploy return an error (which is currently what I coded)

@bep bep closed this as completed in #7868 Oct 23, 2020
bep pushed a commit that referenced this issue Oct 23, 2020
@emhagman
build: Allow optional "nodeploy" tag to exclude deploy command from bin
f465c5c 
Fixes #7826
@bot-actions bot-actions bot mentioned this issue Nov 1, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Nov 2, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.76.5
Development

Successfully merging a pull request may close this issue.

build: allow optional "nodeploy" tag to exclude deploy command from bin emhagman/hugo
3 participants
@fazalmajid @bep @emhagman