Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS minifier broken in 0.76 #7792

Closed
bep opened this issue Oct 7, 2020 · 5 comments
Closed

JS minifier broken in 0.76 #7792

bep opened this issue Oct 7, 2020 · 5 comments
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.76.2

Comments

@bep
Copy link
Member

bep commented Oct 7, 2020

No description provided.

@bep bep self-assigned this Oct 7, 2020
@bep bep added the Bug label Oct 7, 2020
@bep bep added this to the v0.76.2 milestone Oct 7, 2020
@bep bep changed the title Investigate minify breakage in 0.76 JS minifier broken in 0.76 Oct 7, 2020
@bep
Copy link
Member Author

bep commented Oct 7, 2020

I'll revert to what we had in 0.75.1:

github.com/tdewolff/minify/v2 v2.6.2

@bep bep closed this as completed in 6dd60fc Oct 7, 2020
@fmotrifork fmotrifork mentioned this issue Oct 8, 2020
Merged
@tdewolff
Copy link

tdewolff commented Oct 8, 2020

Just curious, did you happen to encounter a new bug?

@moorereason
Copy link
Contributor

Bug report in the forums: https://discourse.gohugo.io/t/0-76-0-breaks-lazy-loading-on-my-website/28696

Previous discussion on the upgrade PR: #7701

@tdewolff
Copy link

tdewolff commented Oct 8, 2020

Thanks @moorereason , I'd like to fix any issue there is with minify so that the latest version can be used with Hugo. However, I'm unable to reproduce the bug in the forums, if anyone can reproduce it please let me know how. With respect to the upgrade PR, I've commented there that the technique used for minification is very common amonst minifiers. Currently I'm unaware of any issues with minify, but please keep me posted when a problem rises.

@bot-actions bot-actions bot mentioned this issue Nov 1, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Nov 2, 2020
Merged
@moorereason moorereason mentioned this issue Dec 1, 2020
Closed
@fntlnz fntlnz mentioned this issue Dec 1, 2020
Merged
7 tasks
fntlnz added a commit to fntlnz/contributor-site that referenced this issue Dec 1, 2020
@fntlnz
Restore website minification via hugo minify
0133622 
It was disabled in kubernetes#131 because hugo is not using tdewolff/minify 2.7.3,
however, the hugo project has been trying to update this but it always
introduces regressions and they are having regressions with the JS
minifier.

- gohugoio/hugo#7701
- gohugoio/hugo#7792

Signed-off-by: Lorenzo Fontana <[email protected]>
fntlnz added a commit to fntlnz/contributor-site that referenced this issue Dec 1, 2020
@fntlnz
Restore website minification via hugo minify
b195020 
It was disabled in kubernetes#131 because hugo is not using tdewolff/minify 2.7.3,
however, the hugo project has been trying to update this but it always
introduces regressions and they are having regressions with the JS
minifier.

- gohugoio/hugo#7701
- gohugoio/hugo#7792

Signed-off-by: Lorenzo Fontana <[email protected]>
@fntlnz fntlnz mentioned this issue Dec 1, 2020
Merged
fntlnz added a commit to fntlnz/contributor-site that referenced this issue Dec 2, 2020
@fntlnz
Restore website minification via hugo minify
d98c944 
It was disabled in kubernetes#131 because hugo is not using tdewolff/minify 2.7.3,
however, the hugo project has been trying to update this but it always
introduces regressions and they are having regressions with the JS
minifier.

- gohugoio/hugo#7701
- gohugoio/hugo#7792

Signed-off-by: Lorenzo Fontana <[email protected]>
fntlnz added a commit to fntlnz/contributor-site that referenced this issue Dec 2, 2020
@fntlnz
Restore website minification via hugo minify
316ee63 
It was disabled in kubernetes#131 because hugo is not using tdewolff/minify 2.7.3,
however, the hugo project has been trying to update this but it always
introduces regressions and they are having regressions with the JS
minifier.

- gohugoio/hugo#7701
- gohugoio/hugo#7792

Signed-off-by: Lorenzo Fontana <[email protected]>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.76.2
Development

No branches or pull requests
3 participants
@moorereason @bep @tdewolff