Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_internal/pagination.html uses "..." though there is no page to skip. #7523

Closed
J-Siu opened this issue Jul 29, 2020 · 2 comments · Fixed by #7527 or #7841
Closed

_internal/pagination.html uses "..." though there is no page to skip. #7523

J-Siu opened this issue Jul 29, 2020 · 2 comments · Fixed by #7527 or #7841
Assignees
@moorereason
Labels
Bug Outdated
Milestone
v0.77

Comments

@J-Siu
Copy link

J-Siu commented Jul 29, 2020

What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.74.3/extended darwin/amd64 BuildDate: unknown

Does this issue reproduce with the latest release?

yes

Can check on my site: https://johnsiu.com

My site currently has 5 pages in list.

The pager is using {{template "_internal/pagination.html" .}}.

If I am on page 1 and page 2, the pager use ... in place of 4 as follow:

    «« « 1 2 3 … 5 » »»
@jmooring jmooring mentioned this issue Jul 31, 2020
Merged
@bep bep closed this as completed in #7527 Jul 31, 2020
@bep bep added this to the v0.75 milestone Jul 31, 2020
bep pushed a commit that referenced this issue Jul 31, 2020
@jmooring @bep
Fix ellipsis display logic in pagination template
2fa851e 
Closes #7523
@bep bep added the Bug label Jul 31, 2020
@fmotrifork fmotrifork mentioned this issue Sep 14, 2020
Merged
@J-Siu
Copy link
Author

J-Siu commented Oct 16, 2020 •
edited
Loading

@bep Should this be reopened? As #7527 is reverted by #7536.

@moorereason moorereason reopened this Oct 16, 2020
@moorereason moorereason modified the milestones: v0.75, v0.77 Oct 16, 2020
moorereason added a commit to moorereason/hugo that referenced this issue Oct 16, 2020
@moorereason
embedded: Always show page number when 5 pages or less
449b1cb 
Fixes gohugoio#7523
@moorereason moorereason mentioned this issue Oct 16, 2020
Merged
@moorereason moorereason self-assigned this Oct 16, 2020
@bep bep closed this as completed in #7841 Oct 16, 2020
bep pushed a commit that referenced this issue Oct 16, 2020
@moorereason @bep
embedded: Always show page number when 5 pages or less
08e4f9f 
Fixes #7523
@bot-actions bot-actions bot mentioned this issue Nov 1, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Nov 2, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@moorereason moorereason

Labels
Bug Outdated
Projects
None yet
Milestone
v0.77
3 participants
@moorereason @bep @J-Siu