Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseof/blocks regression in latest release #7478

Closed
bep opened this issue Jul 13, 2020 · 3 comments · Fixed by #7479
Closed

Baseof/blocks regression in latest release #7478

bep opened this issue Jul 13, 2020 · 3 comments · Fixed by #7479
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.74.1

Comments

@bep
Copy link
Member

bep commented Jul 13, 2020

Looking at the docs site... Probably the inline partial feature, but a little mysterious.
@bep bep added the Bug label Jul 13, 2020
@bep bep added this to the v0.74.1 milestone Jul 13, 2020
@bep bep self-assigned this Jul 13, 2020
@bep
Copy link
Member Author

bep commented Jul 13, 2020

OK, I see it. It happens when you have an empty block:

{{ block "header" . }}{{ end }}

And that header define is missing on, say, the single template. Not great.

@bep bep changed the title Baseof/blocks issue with latest release Baseof/blocks regression in latest release Jul 13, 2020
@bep
Copy link
Member Author

bep commented Jul 13, 2020

To me this looks like a bug in Go that has now surfaced. I need to think a little about how to solve this on the Hugo side of the fence ...

golang/go#40186

@bep bep mentioned this issue Jul 13, 2020
Merged
bep added a commit to bep/hugo that referenced this issue Jul 13, 2020
@bep
Fix baseof block regression
180fbe0 
From Hugo 0.74.0.

Fixes gohugoio#7478
@bep bep closed this as completed in #7479 Jul 13, 2020
bep added a commit that referenced this issue Jul 13, 2020
@bep
Fix baseof block regression
c91dbe4 
From Hugo 0.74.0.

Fixes #7478
@fmotrifork fmotrifork mentioned this issue Jul 15, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Sep 14, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.74.1
Development

Successfully merging a pull request may close this issue.

Fix baseof block regression bep/hugo
1 participant
@bep