Resource transformation key conflict when multiple languages in multihost mode and each with its own content dir #7436

bep · 2020-06-28T16:12:34Z

Which would mean that:

{{ .Resources.GetMatch "*.css" | minify }}

Would give a cached and wrong result for the other languages if the CSS filename is the same.

This would not be the case if you have all content living in the same content folder, e.g.:

index.md
style.en.css
style.fr.css

The text was updated successfully, but these errors were encountered:

This commit also consolidates all (or the most important) memory caches in Hugo. Fixes gohugoio#7425 Fixes gohugoio#7437 Fixes gohugoio#7436

This commit also consolidates all (or the most important) memory caches in Hugo. Fixes gohugoio#7425 Fixes gohugoio#7437 Fixes gohugoio#7436 Updates gohugoio#7544

Hugo has always been a active user of in-memory caches, but before this commit we did nothing to control the memory usage. One failing example would be loading lots of big JSON data files and unmarshal them via `transform.Unmarshal`. This commit consolidates all these caches into one single LRU cache with an eviction strategy that also considers used vs. available memory. Hugo will try to limit its memory usage to 1/4 or total system memory, but this can be controlled with the `HUGO_MEMORYLIMIT` environment variable (a float value representing Gigabytes). A natural next step after this would be to use this cache for `.Content`. Fixes gohugoio#7425 Fixes gohugoio#7437 Fixes gohugoio#7436 Updates gohugoio#7544

Hugo has always been a active user of in-memory caches, but before this commit we did nothing to control the memory usage. One failing example would be loading lots of big JSON data files and unmarshal them via `transform.Unmarshal`. This commit consolidates all these caches into one single LRU cache with an eviction strategy that also considers used vs. available memory. Hugo will try to limit its memory usage to 1/4 or total system memory, but this can be controlled with the `HUGO_MEMORYLIMIT` environment variable (a float value representing Gigabytes). A natural next step after this would be to use this cache for `.Content`. Fixes gohugoio#7425 Fixes gohugoio#7437 Fixes gohugoio#7436 Fixes gohugoio#7882 Updates gohugoio#7544

…, and some general spring cleaning There are some breaking changes in this commit, see gohugoio#11455. Closes gohugoio#11455 Closes gohugoio#11549 Fixes gohugoio#10104 Fixes gohugoio#10380 Fixes gohugoio#10694 Fixes gohugoio#11439 Fixes gohugoio#11453 Fixes gohugoio#11457 Fixes gohugoio#11466 Fixes gohugoio#11540 Fixes gohugoio#11551 Fixes gohugoio#11556 Fixes gohugoio#11654 Fixes gohugoio#11661 Fixes gohugoio#11663 Fixes gohugoio#11840 Fixes gohugoio#11664 Fixes gohugoio#11669 Fixes gohugoio#11671 Fixes gohugoio#11807 Fixes gohugoio#11808 Fixes gohugoio#11809 Fixes gohugoio#11815 Fixes gohugoio#7425 Fixes gohugoio#7436 Fixes gohugoio#7437 Fixes gohugoio#7544 Fixes gohugoio#7882 Fixes gohugoio#8307 Fixes gohugoio#8498 Fixes gohugoio#8927 Fixes gohugoio#9192 Fixes gohugoio#9324 Fixes gohugoio#9343

…, and some general spring cleaning There are some breaking changes in this commit, see gohugoio#11455. Closes gohugoio#11455 Closes gohugoio#11549 Fixes gohugoio#10104 Fixes gohugoio#10380 Fixes gohugoio#10694 Fixes gohugoio#11439 Fixes gohugoio#11453 Fixes gohugoio#11457 Fixes gohugoio#11466 Fixes gohugoio#11540 Fixes gohugoio#11551 Fixes gohugoio#11556 Fixes gohugoio#11654 Fixes gohugoio#11661 Fixes gohugoio#11663 Fixes gohugoio#11664 Fixes gohugoio#11669 Fixes gohugoio#11671 Fixes gohugoio#11807 Fixes gohugoio#11808 Fixes gohugoio#11809 Fixes gohugoio#11815 Fixes gohugoio#11840 Fixes gohugoio#11860 Fixes gohugoio#11883 Fixes gohugoio#7425 Fixes gohugoio#7436 Fixes gohugoio#7437 Fixes gohugoio#7544 Fixes gohugoio#7882 Fixes gohugoio#8307 Fixes gohugoio#8498 Fixes gohugoio#8927 Fixes gohugoio#9192 Fixes gohugoio#9324 Fixes gohugoio#9343

…, and some general spring cleaning There are some breaking changes in this commit, see #11455. Closes #11455 Closes #11549 Fixes #10104 Fixes #10380 Fixes #10694 Fixes #11439 Fixes #11453 Fixes #11457 Fixes #11466 Fixes #11540 Fixes #11551 Fixes #11556 Fixes #11654 Fixes #11661 Fixes #11663 Fixes #11664 Fixes #11669 Fixes #11671 Fixes #11807 Fixes #11808 Fixes #11809 Fixes #11815 Fixes #11840 Fixes #11860 Fixes #11883 Fixes #7425 Fixes #7436 Fixes #7437 Fixes #7544 Fixes #7882 Fixes #8307 Fixes #8498 Fixes #8927 Fixes #9192 Fixes #9324 Fixes #9343

…d some general spring cleaning There are some breaking changes in this commit, see #11455. Closes #11455 Closes #11549 Fixes #10104 Fixes #10380 Fixes #10694 Fixes #11439 Fixes #11453 Fixes #11457 Fixes #11466 Fixes #11540 Fixes #11551 Fixes #11556 Fixes #11654 Fixes #11661 Fixes #11663 Fixes #11664 Fixes #11669 Fixes #11671 Fixes #11807 Fixes #11808 Fixes #11809 Fixes #11815 Fixes #11840 Fixes #11860 Fixes #11883 Fixes #7425 Fixes #7436 Fixes #7437 Fixes #7544 Fixes #7882 Fixes #8307 Fixes #8498 Fixes #8927 Fixes #9192 Fixes #9324 Fixes #9343

…d some general spring cleaning There are some breaking changes in this commit, see #11455. Closes #11455 Closes #11549 Fixes #10169 Fixes #10364 Fixes #10482 Fixes #10630 Fixes #10656 Fixes #10694 Fixes #10918 Fixes #11262 Fixes #11439 Fixes #11453 Fixes #11457 Fixes #11466 Fixes #11540 Fixes #11551 Fixes #11556 Fixes #11654 Fixes #11661 Fixes #11663 Fixes #11664 Fixes #11669 Fixes #11671 Fixes #11807 Fixes #11808 Fixes #11809 Fixes #11815 Fixes #11840 Fixes #11853 Fixes #11860 Fixes #11883 Fixes #11904 Fixes #7388 Fixes #7425 Fixes #7436 Fixes #7544 Fixes #7882 Fixes #7960 Fixes #8255 Fixes #8307 Fixes #8863 Fixes #8927 Fixes #9192 Fixes #9324

…d some general spring cleaning There are some breaking changes in this commit, see #11455. Closes #11455 Closes #11549 This fixes a set of bugs (see issue list) and it is also paying some technical debt accumulated over the years. We now build with Staticcheck enabled in the CI build. The performance should be about the same as before for regular sized Hugo sites, but it should perform and scale much better to larger data sets, as objects that uses lots of memory (e.g. rendered Markdown, big JSON files read into maps with transform.Unmarshal etc.) will now get automatically garbage collected if needed. Performance on partial rebuilds when running the server in fast render mode should be the same, but the change detection should be much more accurate. A list of the notable new features: * A new dependency tracker that covers (almost) all of Hugo's API and is used to do fine grained partial rebuilds when running the server. * A new and simpler tree document store which allows fast lookups and prefix-walking in all dimensions (e.g. language) concurrently. * You can now configure an upper memory limit allowing for much larger data sets and/or running on lower specced PCs. We have lifted the "no resources in sub folders" restriction for branch bundles (e.g. sections). Memory Limit * Hugos will, by default, set aside a quarter of the total system memory, but you can set this via the OS environment variable HUGO_MEMORYLIMIT (in gigabytes). This is backed by a partitioned LRU cache used throughout Hugo. A cache that gets dynamically resized in low memory situations, allowing Go's Garbage Collector to free the memory. New Dependency Tracker: Hugo has had a rule based coarse grained approach to server rebuilds that has worked mostly pretty well, but there have been some surprises (e.g. stale content). This is now revamped with a new dependency tracker that can quickly calculate the delta given a changed resource (e.g. a content file, template, JS file etc.). This handles transitive relations, e.g. $page -> js.Build -> JS import, or $page1.Content -> render hook -> site.GetPage -> $page2.Title, or $page1.Content -> shortcode -> partial -> site.RegularPages -> $page2.Content -> shortcode ..., and should also handle changes to aggregated values (e.g. site.Lastmod) effectively. This covers all of Hugo's API with 2 known exceptions (a list that may not be fully exhaustive): Changes to files loaded with template func os.ReadFile may not be handled correctly. We recommend loading resources with resources.Get Changes to Hugo objects (e.g. Page) passed in the template context to lang.Translate may not be detected correctly. We recommend having simple i18n templates without too much data context passed in other than simple types such as strings and numbers. Note that the cachebuster configuration (when A changes then rebuild B) works well with the above, but we recommend that you revise that configuration, as it in most situations should not be needed. One example where it is still needed is with TailwindCSS and using changes to hugo_stats.json to trigger new CSS rebuilds. Document Store: Previously, a little simplified, we split the document store (where we store pages and resources) in a tree per language. This worked pretty well, but the structure made some operations harder than they needed to be. We have now restructured it into one Radix tree for all languages. Internally the language is considered to be a dimension of that tree, and the tree can be viewed in all dimensions concurrently. This makes some operations re. language simpler (e.g. finding translations is just a slice range), but the idea is that it should also be relatively inexpensive to add more dimensions if needed (e.g. role). Fixes #10169 Fixes #10364 Fixes #10482 Fixes #10630 Fixes #10656 Fixes #10694 Fixes #10918 Fixes #11262 Fixes #11439 Fixes #11453 Fixes #11457 Fixes #11466 Fixes #11540 Fixes #11551 Fixes #11556 Fixes #11654 Fixes #11661 Fixes #11663 Fixes #11664 Fixes #11669 Fixes #11671 Fixes #11807 Fixes #11808 Fixes #11809 Fixes #11815 Fixes #11840 Fixes #11853 Fixes #11860 Fixes #11883 Fixes #11904 Fixes #7388 Fixes #7425 Fixes #7436 Fixes #7544 Fixes #7882 Fixes #7960 Fixes #8255 Fixes #8307 Fixes #8863 Fixes #8927 Fixes #9192 Fixes #9324

github-actions · 2024-02-19T01:48:15Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

bep added the Bug label Jun 28, 2020

bep added this to the v0.74 milestone Jun 28, 2020

bep self-assigned this Jun 28, 2020

bep mentioned this issue Jun 28, 2020

Language code in resource filename kept in RelPermalink #7437

Closed

bep changed the title ~~Resource transformation key conflict when multiple languages and each with its own content dir~~ Resource transformation key conflict when multiple languages in multihost mode and each with its own content dir Jun 28, 2020

bep added a commit to bep/hugo that referenced this issue Jul 8, 2020

Consolidate most memory into a LRU cache

04de6fd

This commit also consolidates all (or the most important) memory caches in Hugo. Fixes gohugoio#7425 Fixes gohugoio#7437 Fixes gohugoio#7436

bep modified the milestones: v0.74, v0.75 Jul 13, 2020

bep added a commit to bep/hugo that referenced this issue Aug 11, 2020

Consolidate most memory into a LRU cache

8e46757

This commit also consolidates all (or the most important) memory caches in Hugo. Fixes gohugoio#7425 Fixes gohugoio#7437 Fixes gohugoio#7436

bep added a commit to bep/hugo that referenced this issue Aug 12, 2020

Consolidate most memory into a LRU cache

656d484

This commit also consolidates all (or the most important) memory caches in Hugo. Fixes gohugoio#7425 Fixes gohugoio#7437 Fixes gohugoio#7436 Updates gohugoio#7544

bep mentioned this issue Aug 15, 2020

Work In Progress: Add central LRU cache that adjusts to available memory #7426

Closed

bep modified the milestones: v0.75, v0.76 Sep 14, 2020

bep modified the milestones: v0.76, v0.77 Oct 6, 2020

bep mentioned this issue Oct 29, 2020

Misc modules improvements/fixes #7905

Merged

bep modified the milestones: v0.77, v0.78 Oct 30, 2020

bep modified the milestones: v0.78, v0.83 Apr 23, 2021

bep mentioned this issue Jan 17, 2024

all: Rework page store, add a dynacache to enable bigger data/content, and some general spring cleaning #11894

Merged

bep modified the milestones: v0.122.0, v0.123.0 Jan 27, 2024

bep closed this as completed in #11894 Jan 28, 2024

bep closed this as completed in e39c0f4 Jan 28, 2024

github-actions bot added the Outdated label Feb 19, 2024

github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resource transformation key conflict when multiple languages in multihost mode and each with its own content dir #7436

Resource transformation key conflict when multiple languages in multihost mode and each with its own content dir #7436

bep commented Jun 28, 2020

github-actions bot commented Feb 19, 2024

Resource transformation key conflict when multiple languages in multihost mode and each with its own content dir #7436

Resource transformation key conflict when multiple languages in multihost mode and each with its own content dir #7436

Comments

bep commented Jun 28, 2020

github-actions bot commented Feb 19, 2024