Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle mount source/target mismatches in .GetPage and live reload #6696

Closed
bep opened this issue Jan 1, 2020 · 1 comment
Closed

Handle mount source/target mismatches in .GetPage and live reload #6696

bep opened this issue Jan 1, 2020 · 1 comment
Labels
Bug Outdated
Milestone
v0.62.1

Comments

@bep
Copy link
Member

bep commented Jan 1, 2020

This is related to #6684

All of this was simpler before we got file mounts. Then what we put in .Path was the source path.

One example config:

[module]
  [[module.mounts]]
    source = "README.md"
    target = "content/_index.md"
  [[module.mounts]]
    source = "blog"
    target = "content/posts"
  [[module.mounts]]
    source = "docs"
    target = "content/docs"

In the above:

  • For the docs mount, the source and target paths matches and everything is OK
  • The two other examples will not work. .GetPage "/README.md" (needed by Allow content mounts to be files #6684) will not return anything and when you change that file in server mode, we currently will not be able to correctly match it to a page.
@bep bep added the Bug label Jan 1, 2020
@bep bep added this to the v0.62.1 milestone Jan 1, 2020
bep added a commit to bep/hugo that referenced this issue Jan 1, 2020
@bep
Support files in content mounts
8d97a8b 
This commit is a general improvement of handling if single file mounts.

Fixes gohugoio#6684
Fixes gohugoio#6696
bep added a commit to bep/hugo that referenced this issue Jan 1, 2020
@bep
Support files in content mounts
c8fde78 
This commit is a general improvement of handling if single file mounts.

Fixes gohugoio#6684
Fixes gohugoio#6696
bep added a commit to bep/hugo that referenced this issue Jan 1, 2020
@bep
Support files in content mounts
46dc657 
This commit is a general improvement of handling if single file mounts.

Fixes gohugoio#6684
Fixes gohugoio#6696
@bep bep closed this as completed in ff6253b Jan 1, 2020
@bep bep mentioned this issue Jan 2, 2020
Closed
jakejarvis pushed a commit to jakejarvis/hugo that referenced this issue Mar 5, 2021
@bep @jakejarvis
Support files in content mounts
c89df70 
This commit is a general improvement of handling if single file mounts.

Fixes gohugoio#6684
Fixes gohugoio#6696
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Outdated
Projects
None yet
Milestone
v0.62.1
Development

No branches or pull requests
1 participant
@bep