Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformations (if/with etc) not applied to not (yet) parsed templates #5865

Closed
bep opened this issue Apr 15, 2019 · 1 comment · Fixed by #5866
Closed

Transformations (if/with etc) not applied to not (yet) parsed templates #5865

bep opened this issue Apr 15, 2019 · 1 comment · Fixed by #5866
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.55.2

Comments

@bep
Copy link
Member

bep commented Apr 15, 2019 •
edited
Loading

https://discourse.gohugo.io/t/error-what-to-replace-file-dir-with-in-hugo-book/18118/15

This isn't a new problem, but the WARNINGs we create for .File is making it more visible than before. I think this should be a rare problem, but I will add a patch for it for 0.55.2.
@bep bep added this to the v0.55.2 milestone Apr 15, 2019
@bep bep self-assigned this Apr 15, 2019
@bep bep changed the title Check if/else vs IsZero Check if/else in define vs IsZero Apr 16, 2019
@bep bep mentioned this issue Apr 16, 2019
Merged
@bep bep changed the title Check if/else in define vs IsZero Transformations (if/with etc) not applied to late templates Apr 16, 2019
bep added a commit to bep/hugo that referenced this issue Apr 16, 2019
@bep
tpl/tplimpl: Handle late transformation of templates
6269c5c 
Fixes gohugoio#5865
@bep bep mentioned this issue Apr 16, 2019
Merged
bep added a commit to bep/hugo that referenced this issue Apr 16, 2019
@bep
tpl/tplimpl: Handle late transformation of templates
25a7142 
Fixes gohugoio#5865
@bep bep changed the title Transformations (if/with etc) not applied to late templates Transformations (if/with etc) not applied to not (yet) parsed templates Apr 16, 2019
bep added a commit to bep/hugo that referenced this issue Apr 16, 2019
@bep
tpl/tplimpl: Handle late transformation of templates
599c7c5 
Fixes gohugoio#5865
alex-shpak pushed a commit to alex-shpak/hugo-book that referenced this issue Apr 16, 2019
@bep @alex-shpak
Adjust .File usage to get rid of WARNINGs
5affd26 
Note that this requires this fix in Hugo 0.55.2:

gohugoio/hugo#5865
bep added a commit to bep/hugo that referenced this issue Apr 16, 2019
@bep
tpl/tplimpl: Handle late transformation of templates
3374c34 
Fixes gohugoio#5865
bep added a commit to bep/hugo that referenced this issue Apr 16, 2019
@bep
tpl/tplimpl: Handle late transformation of templates
ce526e9 
Fixes gohugoio#5865
bep added a commit to bep/hugo that referenced this issue Apr 16, 2019
@bep
tpl/tplimpl: Handle late transformation of templates
c0ce791 
Fixes gohugoio#5865
@bep bep closed this as completed in #5866 Apr 16, 2019
bep added a commit that referenced this issue Apr 16, 2019
@bep
tpl/tplimpl: Handle late transformation of templates
2957795 
Fixes #5865
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.55.2
Development

Successfully merging a pull request may close this issue.

tpl/tplimpl: Handle late transformation of templates bep/hugo
1 participant
@bep