Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontmatter in html comment is suddenly ignored #5478

Closed
binkoni opened this issue Nov 28, 2018 · 2 comments · Fixed by #5479
Closed

Frontmatter in html comment is suddenly ignored #5478

binkoni opened this issue Nov 28, 2018 · 2 comments · Fixed by #5479
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.52

Comments

@binkoni
Copy link

binkoni commented Nov 28, 2018

I have used v0.46 hugo and there were no problems in front matter.
But now frontmatter in a html comment like this is ignored in v0.51
And I didn't tried other versions.
Is this a bug or an intended change?

<!--
+++
title = "hello"
+++
-->
@binkoni binkoni changed the title frontmatter in html comment is suddenly ignored Frontmatter in html comment is suddenly ignored Nov 28, 2018
@bep
Copy link
Member

bep commented Nov 28, 2018

I rewrote the page parser in 0.51 (for many reasons), and I may have interpreted the old "comment out" logic.

@bep bep added this to the v0.52 milestone Nov 28, 2018
@bep bep added the Bug label Nov 28, 2018
@bep bep self-assigned this Nov 28, 2018
bep added a commit to bep/hugo that referenced this issue Nov 28, 2018
@bep
parser/pageparser: Fix handling of commented out front matter
7540a62 
When the page parser was rewritten in 0.51, this was interpreted literally, but commented out front matter is used in the wild to "hide it from GitHub", e.g:

```
<!--
+++
title = "hello"
+++
-->
```

Fixes gohugoio#5478
@bep bep mentioned this issue Nov 28, 2018
Merged
@bep bep closed this as completed in #5479 Nov 28, 2018
@dependencies dependencies bot mentioned this issue Nov 28, 2018
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.52
Development

Successfully merging a pull request may close this issue.

parser/pageparser: Fix handling of commented out front matter bep/hugo
2 participants
@bep @binkoni