Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in append type check #5303

Closed
bep opened this issue Oct 11, 2018 · 3 comments · Fixed by #5304
Closed

Bug in append type check #5303

bep opened this issue Oct 11, 2018 · 3 comments · Fixed by #5304
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.49.2

Comments

@bep
Copy link
Member

bep commented Oct 11, 2018 

executing “partials/include/assets-css.html” at <append (resources.Ge…>: error calling append: append element type mismatch: expected resource.Resource, got *resource.genericResource

https://discourse.gohugo.io/t/bundle-many-resources/13497/11
@bep bep added the Bug label Oct 11, 2018
@bep bep self-assigned this Oct 11, 2018
@bep bep modified the milestones: v0.50, v0.49.2 Oct 11, 2018
@Guite
Copy link

Guite commented Oct 11, 2018

Thank you for this quick reaction! 👍

bep added a commit to bep/hugo that referenced this issue Oct 11, 2018
@bep
common/collections: Fix type checking in Append
f6c1c76 
The fix introduced in Hugo `0.49.1` had an unintended side-effect in the `Append` func used in both `append` and `.Scratch.Add`.

This commit fixes that by loosen/fixing the type checking so concrete types can be appended to interface slices.

Fixes gohugoio#5303
@bep bep mentioned this issue Oct 11, 2018
Merged
bep added a commit to bep/hugo that referenced this issue Oct 11, 2018
@bep
common/collections: Fix type checking in Append
a642a64 
The fix introduced in Hugo `0.49.1` had an unintended side-effect in the `Append` func used in both `append` and `.Scratch.Add`.

This commit fixes that by loosen/fixing the type checking so concrete types can be appended to interface slices.

Fixes gohugoio#5303
bep added a commit to bep/hugo that referenced this issue Oct 11, 2018
@bep
common/collections: Fix type checking in Append
535755e 
The fix introduced in Hugo `0.49.1` had an unintended side-effect in the `Append` func used in both `append` and `.Scratch.Add`.

This commit fixes that by loosen/fixing the type checking so concrete types can be appended to interface slices.

Fixes gohugoio#5303
@bep bep closed this as completed in #5304 Oct 11, 2018
bep added a commit that referenced this issue Oct 11, 2018
@bep
common/collections: Fix type checking in Append
2159d77 
The fix introduced in Hugo `0.49.1` had an unintended side-effect in the `Append` func used in both `append` and `.Scratch.Add`.

This commit fixes that by loosen/fixing the type checking so concrete types can be appended to interface slices.

Fixes #5303
@Guite
Copy link

Guite commented Oct 11, 2018

Works like a charm 🎉

anthonyfok pushed a commit that referenced this issue Oct 11, 2018
@bep @anthonyfok
common/collections: Fix type checking in Append
47f36f0 
The fix introduced in Hugo `0.49.1` had an unintended side-effect in the `Append` func used in both `append` and `.Scratch.Add`.

This commit fixes that by loosen/fixing the type checking so concrete types can be appended to interface slices.

Fixes #5303
@dependencies dependencies bot mentioned this issue Oct 29, 2018
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.49.2
Development

Successfully merging a pull request may close this issue.

common/collections: Fix type checking in Append bep/hugo
2 participants
@Guite @bep