ISO8601 issue with internal template

[akshaybabloo]

This might not be much of an issue, but when using the internal template such as OpenGraph the datetime's offset + or - is not shown. Example

date: 2018-09-20T16:37:20+12:00

is shown as

<meta property="og:updated_time" content="2018-09-20T16:37:20&#43;12:00"/>

Instead of

<meta property="og:updated_time" content="2018-09-20T16:37:20+12:00"/>

I am using Hugo v0.48/extended windows/amd64.

[bep]

How is this a problem?

[rdwatters]

@akshaybabloo.

FYI, the escaped HTML for + wasn't an issue when I tested it locally using Facebook's OGP's debugger. It still converted to UNIX time effectively.

[FelicianoTech]

Hey. This is an issue because safeHTMLAttr shouldn't escape "+"s but it is. I see two components here:

1. The line in Hugo doing this is using safeHTML when it should probably be using safeHTMLAttr.
2. • shouldn't be escaped. This isn't a Hugo issue though as I have tracked it to the html/template Go package. I'm investigating if I can do a PR upstream if I understand it well enough.

[FelicianoTech]

This issue clearly isn't anything major but I made an upstream PR to have Go's html/template stop escaping plus signs and then a PR for Hugo to use the right function.

[akshaybabloo]

This did not fix the issue. I still get

<meta property="og:updated_time" content="2018-09-20T16:37:20&#43;12:00"/>

but this on template works:

{{ print "2018-09-20T16:37:20+12:00" | safeHTML }}

[akshaybabloo]

@rdwatters True, but just for the sake of consistency.

[akshaybabloo]

@FelicianoTech It's not working for me still.

[FelicianoTech]

@akshaybabloo It's not going to until the upstream PR that I linked is merged and a new Hugo release based on that new Go version is released as well.

[Rarst]

I've noticed that schema template is still escaping the plus and not using safeHTMLAttr:

hugo/tpl/tplimpl/embedded/templates/schema.html

Lines 5 to 6 in c3d433a

	<meta itemprop="datePublished" content="{{ .PublishDate.Format $ISO8601 | safeHTML }}" />{{ end }}
	{{ if not .Lastmod.IsZero }}<meta itemprop="dateModified" content="{{ .Lastmod.Format $ISO8601 | safeHTML }}" />{{ end }}

Might have been missed?

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.