-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build related 0.43 tasks #4908
Comments
I have just started tweaking snapcraft.yaml and experimenting with the |
Re. snap, is it possible to deliver 2 versions? I assume there will be people wanting a "pure Go" Hugo version and does not need the SCSS/SASS. |
I think it is possible. Would you like two separate executables in the same snap (easier to do), or two entirely separate snaps? Assuming the first case, how would you like to name the executables? How about |
... Unextended? No, I was more thinking some "snap target" (I'm not sure what that is) ... like dev, extended. If two binaries, then the default should be the one without change, ie. hugo and then hugo-extended. But I'm thinking out loud here. |
Note that the binaries on the release page will be named "hugo" and "hugo_extended"; I think I want them to be named the same, but that will have to wait. |
Snaps can be released into 4 channels, namely "stable", "candidate", "beta" and "edge". IIRC, So, to install what I named While we can create an entirely new snap called At least that is my (limited) understanding of it.
Since most end users do not compile Hugo from source and instead use whatever release binaries are provided to them, I and since Hugo with SCSS support is such a hot feature, I actually think that most people would prefer using the full Hugo (with For me, with my "end user" hat on, I would rather prefer having one single binary but with a runtime flag to disable the SCSS feature if I were to keep using gulp or something else to build my SCSS files. But that's just me and my guess. I could be wrong. ;-)
Is that due to Gorelease not yet being ready for them to be named the same? Or for some other reasons? |
I should have looked more carefully. You've already opened #4916. ;-) |
I spent 8 hours yesterday to get Windows and Darwin builds from a Docker container, and today has also been a whole lot of other troubles, so I think I will postpone the Snap discussion. |
Instead of hugo-extended can it be named just hugo+ Hugo Vs. Hugo-plus benchmark |
About snaps: goreleaser can generate them as well, but it doesn't publish them for now... (there is an issue for that) Once goreleaser can also publish, it would be straightforward to have 2 snaps IMHO... |
Due to snap's design, the name "hugo_extended" needs to be created via an automatic alias request, see https://forum.snapcraft.io/t/hugo-auto-alias-request-for-hugo-extended-hugo-extended/6297 Also migrate from deprecated "prepare", "build" and "install" keywords to "override-build". See #4908
I didn't quite realize the full complexity of the using-Docker-for-Windows-and-Darwin-builds when I first read your tweet, but after seeing what you wrote above, and starting to think about it... Wow, huge task indeed! You are amazing as always! Meanwhile, the Snap build with two binaries is a lot more trivial and seems to be working. I'll make more tweeks and try to match the names
Changes to snapcraft.yaml pushed to master in commit e1027c5. Due to snap's design (to avoid namespace collision), |
@anthonyfok not sure I understand; In the main release we package it in several archives (one extended, one not), but with the same binary. A user wants one of them, not both. So we don't need (want?) different binary names, that would lead to confusion. Does the user have to typo "hugo_extended ...?" |
Yes, with the current snapcraft.yaml that I just committed. So, would you prefer that Hugo snap users use If that is the case, I think we'll need to have a separate snapcraft.yaml with the first line |
Also add verbosity and echo messages to aid debugging. See #4908
Good call in reverting the multi-binary snapcraft.yaml! I went ahead and began a new experimental snap named And should eventually show up at: For the time being, the wrapper executable is called /snap/bin/hugo-extended 😛 unless the end-user set up an alias with
or until 7-day voting period after we file a request for "automatic alias" that is managed at the Snap store: I think we can wait a week or two until all these are sorted out before asking a few volunteers to test and give feedback. :-) |
I'm into all sorts of "does not work" on CircleCI, which is my third day in a row with nothing but trouble ... I think this is a sign from above that I need a vacation ... |
Hang in there! Getting these CI things are very tricky indeed, not to mention such a complicated cross-platform setup with Docker! You are our fearless leader! We have full trust in you! (If you wish, I'd be more than happy to help, though admittedly my experience with Circle CI and Docker are minimal.) |
The CircleCI thing was my fault; I had slipped with some Git resets... I'm getting there... |
Is the extended edition supposed to be a permanent solution? We're talking 2 MB extra, so I can't at the moment see the benefit of having two editions. Do you see other features becoming exclusive to the extended edition in the future? |
Just a final comment on this issue related to our Snap setup for the " The Snapcraft experts recommend the use of tracks to us, which was unbeknownst to me. (/me embarrassed): @chipaca (John Lenton) wrote:
@roadmr (Daniel Manrique) wrote:
I think this is also something that @bep has in his mind in the first place. And, indeed, the Skype Snap is also using the track feature for its "insider" build. No need for "two executables" or a separately named As of today (2018-07-09), we are into the 3-day (or 7-day?) review/voting period for the creation of an I'll be tracking this personally over the next few days, and will build the snaps for both the default track and the "extended" track when it is ready. |
FWIW, GoReleaser can now publish snaps: https://carlosbecker.com/posts/goreleaser-snap-travis/ |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The text was updated successfully, but these errors were encountered: