-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New running "go test ./..." failed
error when building 0.38-DEV
#4538
Comments
Finally figured out why no Using |
You should keep 16.04 as the build system as core is made out of a |
The following is the test result on my laptop.
|
I had this error myself ... somewhere lately. It is related to versioning of this: https://github.com/gohugoio/hugo/blob/master/requirements.txt More specific, the docutils used for the RST rendering tests. If this is somewhat difficult to get working, we can figure a way to skip these tests on the Snap build or whatever. |
Sorry, the RST was a false alarm, as in /usr/bin/rst2html does not exist in the snap build environments at Canonical. According to https://launchpadlibrarian.net/362130797/buildlog_snap_ubuntu_xenial_amd64_hugo-dev_BUILDING.txt.gz, the only FAIL is only this:
|
Some background information:
But TestPageWithLastmodFromGitInfo runs perfectly fine outside of snap build. I wonder what makes the difference? |
Hard to say, I assume this is due to a Git version issue or something. This is not something I want to spend time debugging, so if you got some kind of environment variable we could check for and disable this test on that builder. |
Sorry for taking so long to get back to you. I was able to reproduce "FAIL: TestPageWithLastmodFromGitInfo" running For example, in my local snapcraft test run:
foka@debian ~/snapcraft/hugo/parts/hugo/go/src/github.com/gohugoio/hugo/hugolib (master *=) $ go test -v -run TestPageWithLastmodFromGitInfo === RUN TestPageWithLastmodFromGitInfo gitRepo.TopLevelAbsPath = /home/foka/snapcraft/hugo/parts/hugo/src repoPath = /home/foka/snapcraft/hugo/parts/hugo/src workingDir = /home/foka/snapcraft/hugo/parts/hugo/go/src/github.com/gohugoio/hugo/hugolib/testsite contentDir = home/foka/snapcraft/hugo/parts/hugo/go/src/github.com/gohugoio/hugo/hugolib/testsite/content --- FAIL: TestPageWithLastmodFromGitInfo (0.95s) Error Trace: page_test.go:938 Error: Not equal: expected: "2018-03-11" actual : "2018-02-28" Test: TestPageWithLastmodFromGitInfo FAIL exit status 1 FAIL github.com/gohugoio/hugo/hugolib 0.993s Note how contentDir is missing an initial I suspect some end-users, for whatever strange reasons, might want to work within a symlinked directory. I intend to send a PR to github.com/bep/gitmap to use |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Recent 0.38-DEV failed to build on Canonical's snap autobuild as seen at https://launchpad.net/~gohugoio/+snap/hugo-dev (archived at http://archive.is/ssagJ and http://web.archive.org/web/20180326082235/https://launchpad.net/~gohugoio/+snap/hugo-dev)
hugo (stable) snap 0.37.1 (correctly built and released):
hugo-dev snap 0.38-DEV (failed to build):
Note the
Error: running "go test ./..." failed with exit code 1
error.Somehow, changing the "Distribution series" from Xenial (16.04 LTS) to Artful (17.10) made it "work":
But, judging from the build log,
Error: running "go test ./..." failed with exit code 1
is still there with Artful. It is just that, in the newer version, snapcraft silently ignores thego test
error instead of crashing?(Sorry for causing hugo v0.37.1 to stop working when I applied the wrong fix to this problem in "hugo-dev" snap and an frivolously applied the same "fix" to the stable snap, as reported in #4533, #4534 and #4536)
I will try to run snapcraft locally and see if I could reproduce this issue.
The text was updated successfully, but these errors were encountered: