Remove broken undraft command

[robertbasic]

Hello!

When trying to undraft content with hugo undraft content/blog/article.md Hugo will panic with the following:

panic: interface conversion: interface {} is time.Time, not string

goroutine 1 [running]:
github.com/gohugoio/hugo/commands.undraftContent(0x1f38160, 0xc4203af780, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/gohugoio/hugo/commands/undraft.go:113 +0xc1e
github.com/gohugoio/hugo/commands.Undraft(0x1f92020, 0xc4204bc9c0, 0x1, 0x1, 0x0, 0x0)
	/go/src/github.com/gohugoio/hugo/commands/undraft.go:65 +0x1f4
github.com/gohugoio/hugo/vendor/github.com/spf13/cobra.(*Command).execute(0x1f92020, 0xc4204bc910, 0x1, 0x1, 0x1f92020, 0xc4204bc910)
	/go/src/github.com/gohugoio/hugo/vendor/github.com/spf13/cobra/command.go:746 +0x475
github.com/gohugoio/hugo/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1f90520, 0xf25148, 0xe7ecab, 0x5)
	/go/src/github.com/gohugoio/hugo/vendor/github.com/spf13/cobra/command.go:831 +0x30e
github.com/gohugoio/hugo/commands.Execute()
	/go/src/github.com/gohugoio/hugo/commands/hugo.go:190 +0x60
main.main()
	/go/src/github.com/gohugoio/hugo/main.go:27 +0x36

This only happens when the frontmatter is in the following format (I believe toml):

+++
title = "Draft"
date = 2018-01-29T15:23:04+01:00
draft = true
+++

If the frontmatter is like in the markdown files found in the examples directory (I believe yaml):

---
title: "Draft"
date: 2018-01-29T15:23:04+01:00
draft: true
---

the undrafting goes through OK.

This happens for me with both 0.34, and latest master.

I will try and investigate a bit more, maybe I can submit a patch for this.

[bep]

I think this "undraft" command was not such a good idea. We obviously needs tests for the commands package, but this is not the first time that this command is broken and needs fixing.

I suggest we just remove that command. It feels more natural to just edit the front matter with a text editor.

[robertbasic]

@bep that's what I was doing originally, just change the draft to false while editing, but then I noticed that if I run hugo with hugo -ws . and I undraft a piece of content by "manual" editing, hugo doesn't pick up the newly undrafted content. Would you like me to open a new issue for that?

[bep]

Would you like me to open a new issue for that?

I suspect that is the "fast render mode" talking. There is a recent issue + PR about that.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.