Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme param "theme" breaks build. #4352

Closed
MoritzFago opened this issue Jan 29, 2018 · 1 comment · Fixed by #4358
Closed

theme param "theme" breaks build. #4352

MoritzFago opened this issue Jan 29, 2018 · 1 comment · Fixed by #4358
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.35

Comments

@MoritzFago
Copy link

MoritzFago commented Jan 29, 2018 •
edited
Loading

In the hyde-x theme (see my fork), you have a parameter called "theme" to set the color scheme of the theme. This worked in hugo ~0.19, in hugo 0.34 it breaks the build process in a rather surprising way: no content gets generated, and there isn't any errors, there are a lot of warnings about files it can't find, despite them being there.
if i have

[params]
    # Changes sidebar background and link/accent colours.
    # See below for more colour options.
    # This also works: "theme-base-08 layout-reverse", or just "layout-reverse".
    theme = "theme-base-08"

in my config.toml, it breaks.

hugo version:

Hugo Static Site Generator v0.34 darwin/amd64 BuildDate:
@bep bep added the Bug label Jan 29, 2018
@bep bep self-assigned this Jan 29, 2018
@bep bep added this to the v0.35 milestone Jan 29, 2018
@bep bep mentioned this issue Jan 30, 2018
Closed
bep added a commit to bep/hugo that referenced this issue Jan 30, 2018
@bep
Fix language params handling
59816de 
This fixes some issues with language params handling by separating params from configuration values per language.

This means that you can now do this:

```toml
[languages]
[languages.en]
languageName = "English"
weight = 1
title = "My Cool Site"
[languages.en.params]
myParam = "Hi!"
```

This is not a breaking change, but the above is a less suprising way of configuring custom params.

It also fixes some hard-to-debug corner-cases in multilingual sites.

Fixes gohugoio#4356
Fixes gohugoio#4352
@bep bep mentioned this issue Jan 30, 2018
Merged
bep added a commit to bep/hugo that referenced this issue Jan 30, 2018
@bep
Fix language params handling
3d8b122 
This fixes some issues with language params handling by separating params from configuration values per language.

This means that you can now do this:

```toml
[languages]
[languages.en]
languageName = "English"
weight = 1
title = "My Cool Site"
[languages.en.params]
myParam = "Hi!"
```

This is not a breaking change, but the above is a less suprising way of configuring custom params.

It also fixes some hard-to-debug corner-cases in multilingual sites.

Fixes gohugoio#4356
Fixes gohugoio#4352
@bep bep closed this as completed in #4358 Jan 30, 2018
bep added a commit that referenced this issue Jan 30, 2018
@bep
Fix language params handling
ae742cb 
This fixes some issues with language params handling by separating params from configuration values per language.

This means that you can now do this:

```toml
[languages]
[languages.en]
languageName = "English"
weight = 1
title = "My Cool Site"
[languages.en.params]
myParam = "Hi!"
```

This is not a breaking change, but the above is a less suprising way of configuring custom params.

It also fixes some hard-to-debug corner-cases in multilingual sites.

Fixes #4356
Fixes #4352
@dependencies dependencies bot mentioned this issue Jan 31, 2018
Merged
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.35
Development

Successfully merging a pull request may close this issue.

Fix language params handling bep/hugo
2 participants
@bep @MoritzFago