Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shortcodes with .ace extensions fail #4051

Closed
igregson opened this issue Nov 4, 2017 · 2 comments · Fixed by #4099
Closed

shortcodes with .ace extensions fail #4051

igregson opened this issue Nov 4, 2017 · 2 comments · Fixed by #4099
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.31

Comments

@igregson
Copy link
Contributor

igregson commented Nov 4, 2017

Greetings.

In older versions of Hugo (0.18 I believe, though I'm not certain) it was possible to write shortcodes in ace (e.g. video.ace). When trying this with the latest 0.30.2 this no longer seems to work (and I tried adding html before and after ace, e.g. video.html.ace and video.ace.html, but neither of these worked either).

Not sure if this is a bug or changed behavior (if it's changed behavior it would be good to update the shortcode and ace docs accordingly).
@bep bep added the Bug label Nov 11, 2017
@bep bep added this to the v0.32 milestone Nov 11, 2017
@xap5xap
Copy link

xap5xap commented Nov 17, 2017

Same thing happened to me too

@bep bep self-assigned this Nov 18, 2017
@bep bep modified the milestones: v0.32, v0.31 Nov 18, 2017
bep added a commit to bep/hugo that referenced this issue Nov 18, 2017
@bep
Fix broken shortcodes for Ace and Amber
e7bd741 
Fixes gohugoio#4051
@bep bep mentioned this issue Nov 18, 2017
Merged
@bep bep closed this as completed in #4099 Nov 18, 2017
bep added a commit that referenced this issue Nov 18, 2017
@bep
Fix broken shortcodes for Ace and Amber
503ca6d 
Fixes #4051
@dependencies dependencies bot mentioned this issue Nov 20, 2017
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.31
Development

Successfully merging a pull request may close this issue.

Fix broken shortcodes for Ace and Amber bep/hugo
3 participants
@bep @xap5xap @igregson