-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docker image #12885
Comments
So, the image will need to be able to build a Hugo site. If that's not the case, please create a bug, but I'm not taking improvement requests for this particular feature. It was supposed to be a simple thing and we have already spent hundreds of hours on it. @jmooring I'm closing this, create a new bug track the actual bug. If the image as it is is not useful, lets just remove it. We don't have the budget to maintain all the bells and whistles. |
I'm reopening this, the timing of this got me a little grumpy. We have spent a stupid amount of time just getting the build setup working, and I kind of assumed that the people who started that process found the Docker image we've had living in the project for years both working and useful. That said, I'm already maintaining 2 complex Docker files for the Hugo build, I'm not adding another to that plate, so let us focus on the "getting it in a working state",. |
The purpose of this issue is to solicit community feedback and hopefully reach some consensus.
As of v0.135.0 I can do things like1:
But I can't build the site like this:
Instead, I have to pass an empty entry point:
Or pass in a CLI flag to override the default
--help
flag defined in the Dockerfile. For example:Additionally, the current version:
cacheDir
/HUGO_CACHEDIR
/os.CacheDir
)Now that we can build an image, it would be good to define what we actually want it to do.
Some time ago I created a repo to test docker images:
https://github.com/jmooring/hugo-docker-test
Our Docker image doesn't need to pass that test, but we should consider what we want to support:
https://github.com/jmooring/hugo-docker-test?tab=readme-ov-file#site-characteristics
There's an open issue about how to document usage:
gohugoio/hugoDocs#2727
Footnotes
The
-u $(id -u):$(id -g)
flag is required to set correct permissions on published files. Without this, owner and group were set to root during my Linux testing. ↩The text was updated successfully, but these errors were encountered: