Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify issue (tdewolff/minify #623) #11633

Closed
brycewray opened this issue Oct 30, 2023 · 4 comments · Fixed by #11634
Closed

Minify issue (tdewolff/minify #623) #11633

brycewray opened this issue Oct 30, 2023 · 4 comments · Fixed by #11634

Comments

@brycewray
Copy link

brycewray commented Oct 30, 2023

Using Hugo 0.120.0 (macOS on ARM). Apparently a bug was just fixed moments ago in tdewolff/minify:

tdewolff/minify#623

. . . and I have seen it in local testing of Hugo 0.120.0 as follows:

Error: error building site: MINIFY: failed to transform "js/lite-yt-embed_2023-10-04_v3-0-0.js" (text/javascript): unexpected return in expression on line 87 and column 39
   87:         if (LiteYTEmbed.preconnected) return;

. . . a line which presented no problems prior to Hugo 0.120.0.

@jmooring
Copy link
Member

jmooring commented Oct 30, 2023

@tdewolff Please roll a release when you have a moment. Thanks.

@tdewolff
Copy link

We're all working in parallel it seems! Haha, v2.20.1 just released!

@brycewray
Copy link
Author

brycewray commented Oct 30, 2023

Fixed by 2bedcf3 (and now in 0.120.1).

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants