Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji codes are not converted, and disappear, when using the RenderShortcodes method #11587

Closed
jmooring opened this issue Oct 20, 2023 · 1 comment · Fixed by #11593
Closed

Comments

@jmooring
Copy link
Member

jmooring commented Oct 20, 2023

Not sure if we could resolve this by adding the yuin/goldmark-emoji extension, which solves another problem too, but it's worth a test.

See #7332 (comment).

Tested with enableEmoji= true in site configuration.


Update: I enabled the yuin/goldmark-emoji extension, and set enableEmoji= false. Fixes the problem. I think it makes sense to add that extension, disabled by default.

jmooring added a commit to jmooring/hugo that referenced this issue Oct 20, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Oct 20, 2023
@bep bep added this to the v0.120.0 milestone Oct 21, 2023
@bep bep removed the NeedsTriage label Oct 21, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Oct 22, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Oct 23, 2023
Removes emoji code conversion from the page and shortcode parsers. Emoji
codes in markdown are now passed to Goldmark, where the goldmark-emoji
extension converts them to decimal numeric character references.

This disables emoji rendering for the alternate content formats: html,
asciidoc, org, pandoc, and rst.

Fixes gohugoio#7332
Fixes gohugoio#11587
bep pushed a commit that referenced this issue Oct 24, 2023
Removes emoji code conversion from the page and shortcode parsers. Emoji
codes in markdown are now passed to Goldmark, where the goldmark-emoji
extension converts them to decimal numeric character references.

This disables emoji rendering for the alternate content formats: html,
asciidoc, org, pandoc, and rst.

Fixes #7332
Fixes #11587
Closes #11598
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants