Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu template in theme skeleton throws empty warnings with --printI18nWarnings flag #11519

Closed
jmooring opened this issue Oct 4, 2023 · 1 comment · Fixed by #11520
Closed

Menu template in theme skeleton throws empty warnings with --printI18nWarnings flag #11519

jmooring opened this issue Oct 4, 2023 · 1 comment · Fixed by #11520
Assignees
@jmooring
Labels
Bug Outdated
Milestone
v0.120.0

Comments

@jmooring
Copy link
Member

jmooring commented Oct 4, 2023

The menu partial in the embedded theme skeleton attempts to translate empty identifiers, resulting in empty warnings when building site with the --printI81nWarnings CLI flag.

Reference https://discourse.gohugo.io/t/find-missing-translations/46502/
@jmooring jmooring self-assigned this Oct 4, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Oct 4, 2023
@jmooring
create/skeletons: Fix menu template
55ae91d 
Check identifier existence before calling lang.Translate to prevent
empty warnings when using the --printI18nWarnings flag.

Closes gohugoio#11519
@jmooring jmooring mentioned this issue Oct 4, 2023
Merged
jmooring added a commit to jmooring/hugo that referenced this issue Oct 4, 2023
@jmooring
create/skeletons: Fix menu template
9563442 
Check identifier existence before calling lang.Translate to prevent
empty warnings when using the --printI18nWarnings flag.

Closes gohugoio#11519
@bep bep added this to the v0.120.0 milestone Oct 5, 2023
bep pushed a commit that referenced this issue Oct 30, 2023
@jmooring @bep
create/skeletons: Fix menu template
acf01bf 
Check identifier existence before calling lang.Translate to prevent
empty warnings when using the --printI18nWarnings flag.

Closes #11519
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Bug Outdated
Projects
None yet
Milestone
v0.120.0
Development

Successfully merging a pull request may close this issue.

create/skeletons: Fix menu template jmooring/hugo
2 participants
@jmooring @bep