Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goldmark: ARIA role attribute in Markdown content is not rendered #10661

Closed
MasterKale opened this issue Jan 27, 2023 · 2 comments · Fixed by #10696
Closed

Goldmark: ARIA role attribute in Markdown content is not rendered #10661

MasterKale opened this issue Jan 27, 2023 · 2 comments · Fixed by #10696

Comments

@MasterKale
Copy link

MasterKale commented Jan 27, 2023

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.83.1-5AFE0A57+extended darwin/amd64 BuildDate=2021-05-02T14:38:05Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?

Yes, I confirmed it's still an issue with v0.110.0:

$ hugo version
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended darwin/arm64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio

Context

I was testing out Hugo's Markdown attribute support with the following text in a .md file in content/posts/:

blah blah blah
{.note role="note" data-hello="world"}

Hugo drops the role="note" attribute when it renders the <p> element:

Screenshot 2023-01-27 at 9 23 29 AM

It's desirable to be able to define ARIA attributes like this for those sites that aim to better support screen readers and accessibility in general.

@jmooring
Copy link
Member

yuin/goldmark#358

@jmooring jmooring self-assigned this Jan 28, 2023
@jmooring jmooring changed the title ARIA role attribute in Markdown content is not rendered Goldmark: ARIA role attribute in Markdown content is not rendered Feb 3, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Feb 4, 2023
@bep bep closed this as completed in #10696 Feb 5, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants